Skip to content

Double clicking on the drag bar to maximize does not update the maximize button icon #1780

New issue
New issue
Closed
#3025
Closed
Double clicking on the drag bar to maximize does not update the maximize button icon#1780
#3025
Assignees
DHowett-MSFT
Labels
Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1910

Description

@ocalvo
Oscar Calvo (ocalvo)
opened on Jul 2, 2019

Double clicking on the drag bar to maximize does not update the maximize button icon, the icon remains the same, by contrast, if you click the maximize button the icon does update.

Environment

Windows 10 19H1
Windows Terminal version (if applicable): master

Any other software?

Steps to reproduce

  1. Start Windows Terminal in normal state
  2. Double click the drag bar to maximize the window.

Expected behavior

The maximize button icon is updated

Actual behavior

The maximize button icon does not update.

We are not listening from window state change events from the top level window into the mixmaxclose user control.

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 2, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 2, 2019
  3. Mike Griese (zadjii-msft)
    added
    Area-UserInterfaceIssues pertaining to the user interface of the Console or Terminal
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Product-TerminalThe new Windows Terminal.
    on Jul 2, 2019
  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jul 2, 2019
  5. Mike Griese (zadjii-msft)
    added this to the Terminal v0.3 - Preview 2 milestone on Jul 2, 2019
  6. Rich Turner (bitcrazed)
    added
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    and removed
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jul 2, 2019

  7. gopalrander commented on Jul 5, 2019

    @gopalrander
    Gopal Rander (gopalrander)
    on Jul 5, 2019

    Debugged and noticed that MinMaxCloseControl::DragBar_DoubleTapped() method is not hit when I double clicked the Drag bar. [But the window maximizes; strange?

  8. DHowett-MSFT commented on Jul 5, 2019

    @DHowett-MSFT
    Dustin L. Howett (MSFT) (DHowett-MSFT)
    on Jul 5, 2019
    Contributor

    Gopal Rander (@gopalrander) the drag bar is actually cut out of the window using a region. It's a complicated story about why exactly we need to do this.

  9. Mike Griese (zadjii-msft)
    self-assigned this
    on Jul 11, 2019
  10. Mike Griese (zadjii-msft)
    modified the milestones: Terminal v0.3, Terminal 1908.1 on Jul 31, 2019

  11. 12 remaining items

  12. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added 2 commits that reference this issue on Oct 1, 2019

    Propagate window style changes to the titlebar and minmax

    92ca8ec

    Propagate window style changes to the titlebar and minmax

    601f257
  13. ghost added
    In-PRThis issue has a related PR
    on Oct 1, 2019
  14. Mike Griese (zadjii-msft)
    modified the milestones: Terminal-1911, Terminal-1910 on Oct 2, 2019
  15. Mike Griese (zadjii-msft)
    assigned
    Dustin L. Howett (MSFT) (DHowett-MSFT)
    and unassigned
    Mike Griese (zadjii-msft)
    and
    Kayla Cinnamon (cinnamon-msft)
    on Oct 2, 2019
  16. Carlos Zamora (carlos-zamora)
    closed this as completedin #3025on Oct 2, 2019
  17. Carlos Zamora (carlos-zamora)
    added a commit that references this issue on Oct 2, 2019

    Propagate window style changes to the titlebar and minmax (#3025)

    64c98db
  18. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Oct 2, 2019
  19. ghost removed
    In-PRThis issue has a related PR
    on Oct 2, 2019
  20. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Oct 2, 2019
  21. Dustin L. Howett (MSFT) (DHowett-MSFT)
    added a commit that references this issue on Oct 3, 2019

    Propagate window style changes to the titlebar and minmax (#3025)

    5b33c66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-UserInterfaceIssues pertaining to the user interface of the Console or TerminalIssue-TaskIt's a feature request, but it doesn't really need a major design.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions