Skip to content

Backspaces we insert into a command for a useCommandline suggestion show up in the suggestions UI #16577

New issue
New issue
Closed
#17261
Closed
Backspaces we insert into a command for a useCommandline suggestion show up in the suggestions UI#16577
#17261
Assignees
zadjii-msft
Labels
Area-SuggestionsAnything related to tasks or the suggestions UI (sxnui)In-PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.
Milestone
Terminal v1.21

Description

@zadjii-msft
Mike Griese (zadjii-msft)
opened on Jan 19, 2024

v1.19

  1. add an action like 
         {
         "command": 
         {
             "action": "sendInput",
             "input": "git status"
         },
     },
  2. Enable shell integration
  3. type git at the prompt
  4. Do a showSuggestions("source": [ "tasks", "commandHistory" ], "useCommandline": true). The suggested task looks like

image

The backspaces we inserted? Those show up in the name. They shouldn't. We can probably manually remove them, if we know the command didn't have a specific name set.

Activity

  1. microsoft-github-policy-service
    added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 19, 2024
  2. Mike Griese (zadjii-msft)
    added
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Product-TerminalThe new Windows Terminal.
    Area-SuggestionsAnything related to tasks or the suggestions UI (sxnui)
    on Jan 19, 2024
  3. Carlos Zamora (carlos-zamora)
    added this to the Terminal 1.21 milestone on Jan 24, 2024
  4. Carlos Zamora (carlos-zamora)
    removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 24, 2024
  5. microsoft-github-policy-service
    added
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 24, 2024
  6. Mike Griese (zadjii-msft)
    self-assigned this
    on Feb 8, 2024
  7. Mike Griese (zadjii-msft)
    added a commit that references this issue on Feb 21, 2024

    Don't generate names with visualized SPC and BS for the sxnui

    01ca03f
  8. Mike Griese (zadjii-msft)
    added a commit that references this issue on May 2, 2024

    Squashed commit of the following:

    0ec5aef
  9. Mike Griese (zadjii-msft)
    added a commit that references this issue on May 13, 2024

    Don't generate names with visualized SPC and BS for the sxnui

    c58fbae
  10. microsoft-github-policy-service
    added
    In-PRThis issue has a related PR
    on May 13, 2024
  11. github-merge-queue
    added a commit that references this issue on May 14, 2024

    Remove spaces from snippets in the SXNUI (#17261)

    54cfb85
  12. Dustin L. Howett (DHowett)
    closed this as completedin #17261on May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-SuggestionsAnything related to tasks or the suggestions UI (sxnui)In-PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsProduct-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions