Fragments should be able to add actions #16063

Activity

1. microsoft-github-policy-service

   added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Sep 29, 2023
2. Mike Griese (zadjii-msft)

   added

   Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

   Area-SettingsIssues related to settings and customizability, for console or terminalIssues related to settings and customizability, for console or terminal

   Product-TerminalThe new Windows Terminal.The new Windows Terminal.

   and removed

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Sep 29, 2023
3. microsoft-github-policy-service

   removed

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Sep 29, 2023
4. Mike Griese (zadjii-msft)

   added this to the Up Next milestone on Sep 29, 2023
5. zadjii-msft commented on Sep 29, 2023

   

   Mike Griese (zadjii-msft)

   on Sep 29, 2023

   Last edited by zadjii-msft

   MemberAuthor

   More actions

   I think we'd need to:

   • Add an internal / private source to actions, to indicate where we got the action from (ala profiles)
   • in SettingsLoader::_parseFragment move them all over into the user settings
   • don't serialize ones back that weren't from the user settings

   NOPE not that

   • GlobalAppSettings::_FinalizeInheritance sets the LeastImportantParent for the user's action map on each parent global settings. Well, easy enough.
   • Create a "blank" GAS for each fragment
   • don't parse keys
   • add as a parent of the user's GAS
6. Mike Griese (zadjii-msft)

   modified the milestones: Up Next, Terminal v1.20 on Oct 17, 2023
7. Mike Griese (zadjii-msft)

   self-assigned this

   on Oct 17, 2023
8. microsoft-github-policy-service

   added

   In-PRThis issue has a related PRThis issue has a related PR

   on Oct 17, 2023
9. Mike Griese (zadjii-msft)

   modified the milestones: Terminal v1.20, Terminal 1.21 on Jan 31, 2024
10. Mike Griese (zadjii-msft)

    closed this as completedin #16185on Feb 26, 2024
11. Mike Griese (zadjii-msft)

    added a commit that references this issue on Feb 26, 2024

    Add support for actions in fragments (#16185)

    ...

    This issue will close once commit 88def9d is merged into the 'main' branch.

    88def9d
12. microsoft-github-policy-service

    added

    Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

    on Feb 26, 2024