[1.19] Serious regression in UIA notifications support (typed characters are sent as notifications) #16044

Activity

1. microsoft-github-policy-service

   added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Sep 27, 2023
2. DHowett commented on Sep 27, 2023

   

   Dustin L. Howett (DHowett)

   on Sep 27, 2023

   Member

   More actions

   Hey Bill Dengler (@codeofdusk)! I am guessing that you're using Command Prompt? If so, Leonard Hecker (@lhecker)'s recent input rewrite is almost certainly related. We redraw the entire command for each input. I thought that we had handling in Terminal to suppress those duplicate/overly long notifications...
3. codeofdusk commented on Sep 27, 2023

   

   Bill Dengler (codeofdusk)

   on Sep 27, 2023

   ContributorAuthor

   More actions

   Hey Bill Dengler (@codeofdusk)! I am guessing that you're using Command Prompt?

   No, wt.exe. conhost doesn't support UIA notifications at all as far as I understand.
4. codeofdusk commented on Sep 27, 2023

   

   Bill Dengler (codeofdusk)

   on Sep 27, 2023

   ContributorAuthor

   More actions

   Oh, weird and weirder!

   Since my default terminal is wt, I run cmd from the run dialog and the bug repros. But if I launch wt from run instead, the terminal that opens is fine, even if I start cmd from inside it (it defaults to PowerShell).
5. lhecker commented on Sep 27, 2023

   

   Leonard Hecker (lhecker)

   on Sep 27, 2023

   Last edited by lhecker

   Member

   More actions

   I think your default terminal is probably Windows Terminal Preview, but your wt alias still points to the regular Windows Terminal which doesn't have this bug yet.

   Even in the old Windows Terminal it would announce the entire prompt again and again if you were inserting text in the middle or beginning, right? 1.19 behaves as if this was always the case.

   To fix this we'll simply reintroduce the same optimization we had before: When inserting at the end, we don't move the cursor and just write the new text out without reprinting the entire string. This will unfortunately also reintroduce certain edge cases, like the scrolling that happens when the prompt is longer than the viewport, but it'll fix this issue which is more serious.
6. Leonard Hecker (lhecker)

   added

   Product-ConhostFor issues in the Console codebaseFor issues in the Console codebase

   Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

   Priority-1A description (P1)A description (P1)

   Area-CookedReadThe cmd.exe COOKED_READ handlingThe cmd.exe COOKED_READ handling

   and removed

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Sep 27, 2023
7. Leonard Hecker (lhecker)

   self-assigned this

   on Sep 27, 2023
8. microsoft-github-policy-service

   added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Sep 27, 2023
9. Leonard Hecker (lhecker)

   changed the title [-]Serious regression in UIA notifications support (typed characters are sent as notifications)[/-] [+][1.19] Serious regression in UIA notifications support (typed characters are sent as notifications)[/+] on Sep 27, 2023
10. microsoft-github-policy-service

    added

    In-PRThis issue has a related PRThis issue has a related PR

    on Oct 5, 2023
11. Dustin L. Howett (DHowett)

    closed this as completedin #16105on Oct 24, 2023
12. Dustin L. Howett (DHowett)

    added 2 commits that reference this issue on Oct 24, 2023

    Fix UIA and marks regressions due to cooked read (#16105)

    ...

    This issue will close once commit e1c69a9 is merged into the 'main' branch.

    e1c69a9

    Fix UIA and marks regressions due to cooked read (#16105)

    ...

    This issue will close once commit c2fde69 is merged into the 'main' branch.

    c2fde69
13. js324

    added a commit that references this issue on Dec 7, 2023

    Fix UIA and marks regressions due to cooked read (microsoft#16105)

    ...

    This issue will close once commit 8e94596 is merged into the 'main' branch.

    8e94596