You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
brightBlack and black color values from Solarized Dark Color Scheme are swapped #14684
the Solarized Dark Color Scheme default values should be black = #073642 brBlack = #002b36
In VSCode Terminal running in WSL2: Ubuntu-20.04 the color schema seems to be correct. But running the same WSL2 Distro but this time in Windows Terminal, the black and brBlack colors are swapped.
You can visually confirm this by running the colortest-256 test application on both environments:
VSCode Terminal:
Windows Terminal:
Expected Behavior
Both VSCode and Windows Terminal should be able to reproduce the same colors when selecting the same Color Theme/Schema (In this case, Solarized Dark).
I know this can be easily solved at "user configuration" level, but it would be better to have the correct values by default.
Actual Behavior
By using vim, the color swap effect is more noticeable
The black and brightBlack colors were deliberately swapped in PR #6985 to try and cut down on the constant stream of bug reports we were receiving from people using the Solarized color schemes, because the default mapping tends to produce color combinations that are invisible.
Activity
j4james commentedon Jan 15, 2023
The black and brightBlack colors were deliberately swapped in PR #6985 to try and cut down on the constant stream of bug reports we were receiving from people using the Solarized color schemes, because the default mapping tends to produce color combinations that are invisible.
zadjii-msft commentedon Jan 16, 2023
DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED:
1950Thanks for the callback James Holderness (@j4james), I totally forgot about that PR. I'll concur, this is by design.