Skip to content

brightBlack and black color values from Solarized Dark Color Scheme are swapped #14684

Closed as not planned

Description

@nachopitt

Windows Terminal version

1.15.3465.0

Windows build number

No response

Other Software

VSCode 1.74.2 with Solarized Dark Color Theme selected
vim 8.1.2262 (inside WSL2)
colortest-256

Steps to reproduce

According to the colors table in https://en.wikipedia.org/wiki/Solarized

image

the Solarized Dark Color Scheme default values should be
black = #073642
brBlack = #002b36

In VSCode Terminal running in WSL2: Ubuntu-20.04 the color schema seems to be correct. But running the same WSL2 Distro but this time in Windows Terminal, the black and brBlack colors are swapped.

You can visually confirm this by running the colortest-256 test application on both environments:

VSCode Terminal:
image

Windows Terminal:
image

Expected Behavior

Both VSCode and Windows Terminal should be able to reproduce the same colors when selecting the same Color Theme/Schema (In this case, Solarized Dark).

I know this can be easily solved at "user configuration" level, but it would be better to have the correct values by default.

Actual Behavior

By using vim, the color swap effect is more noticeable

VSCode Terminal
image

Windows Terminal
image

Activity

  1. added
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jan 15, 2023
  2. j4james commented on Jan 15, 2023

    @j4james
    Collaborator

    The black and brightBlack colors were deliberately swapped in PR #6985 to try and cut down on the constant stream of bug reports we were receiving from people using the Solarized color schemes, because the default mapping tends to produce color combinations that are invisible.

  3. zadjii-msft commented on Jan 16, 2023

    @zadjii-msft
    Member

    DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: 195 0

    Thanks for the callback James Holderness (@j4james), I totally forgot about that PR. I'll concur, this is by design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingResolution-By-DesignIt's supposed to be this way. Sometimes for compatibility reasons.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions