Skip to content

OSC 12 "set cursor color" not working, in atlas engine #14533

Closed

Description

    @DHowett @mattwojo sorry to dig this old thread up, but if I do a `printf %b '\e]12;red\a'`, should I expect the cursor color to change to red?  Using terminal preview version 1.16.2641.0, doing the above in wsl, I don't see the cursor color changing.  It retains the original color specified via the color theme in the settings.

image

Originally posted by damnskippy in #184 (comment)

Interestingly enough, if I lock my screen (Windows-L) and unlock it the cursor has then changed its color. image

after locking and unlocking: image

I bet we don't do an invalidate of the screen.

Nah I dunno what this is. We should move this over to the Terminal repo cause I see this too. Even with the rgb: specs too.

(from MicrosoftDocs/terminal#620)

Version number unknown.

printf '\e]12;red\a Foo bar' ; sleep 3
printf '\e]12;rgb:ff/00/00\a Foo bar' ; sleep 3
@echo off
if (%1)==() (goto :usage)
if (%2)==() (goto :usage)
if (%3)==() (goto :usage)

@rem this is a literal ESC and BEL in this next line
echo �]12;rgb:%1/%2/%3�
goto :EOF

:usage
echo Usage: cursor-color ^<red^> ^<green^> ^<blue^>
echo     where red, green, blue are color components in hex
echo     Ex: cursor-color FF 00 FF will set the cursor to �[38;2;255;0;255mMagenta�[0m
echo:

:EOF

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Dec 12, 2022
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Dec 12, 2022
  3. added
    Area-VTVirtual Terminal sequence support
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    on Dec 12, 2022
  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Dec 12, 2022
  5. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Dec 12, 2022
  6. zadjii-msft commented on Dec 12, 2022

    @zadjii-msft
    MemberAuthor

    I can confirm that the cursor changes did seem to reappear after a lock/unlock of my machine! That makes me think there's still an invalidation issue. Maybe in the Atlas engine? IDK if damnskippy was on 1.15 or 1.16

  7. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Dec 12, 2022
  8. changed the title [-]OSC 12 "set cursor color" not working[/-] [+]OSC 12 "set cursor color" not working, in atlas engine[/+] on Dec 12, 2022
  9. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Dec 12, 2022
  10. damnskippy commented on Dec 13, 2022

    @damnskippy

    Thank you for picking this up Mike Griese (@zadjii-msft), and I'm glad/relieved this is reproducible on your end locally. I don't know how to determine the version on Atlas Engine. If there's a command or something that can be run that will produce this, I'd be happy to do so if it's of use.

  11. zadjii-msft commented on Dec 13, 2022

    @zadjii-msft
    MemberAuthor

    damnskippy oh _ don't mean the "atlas engine version", I more just meant the Terminal version, which you can find in the About dialog. The Atlas engine was added in 1.16, but isn't in 1.15.

  12. damnskippy commented on Dec 13, 2022

    @damnskippy

    Oh, Terminal (Preview) version is 1.16.2641.0.

  13. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 11, 2023
  14. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-AtlasEngineIn-PRThis issue has a related PRIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-3A description (P3)Product-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions