Repository navigation
[profiles] What should I do to actually delete these profiles? #13451
Description
Windows Terminal version
1.13.11431.0
Windows build number
10.0.19043.0
Other Software
No response
Steps to reproduce
After I delete these profiles, and reopen the wt, and going to add a new profile, I find they are still existing.
Expected Behavior
These profiles are actually deleted.
Actual Behavior
These profiles are still existing.
Activity
[-][profiles] I want to actually delete this profiles, what should I do?[/-][+][profiles] I want to actually delete these profiles, what should I do?[/+][-][profiles] I want to actually delete these profiles, what should I do?[/-][+][profiles] What should I do to actually delete these profiles?[/+]zadjii-msft commentedon Jul 7, 2022
Did you hit
Saveafter deleting them? Could you share your settings.json file/?NekoAria commentedon Jul 7, 2022
Yes.
NekoAria commentedon Jul 7, 2022
{ "$help": "https://aka.ms/terminal-documentation", "$schema": "https://aka.ms/terminal-profiles-schema", "actions": [ { "command": { "action": "copy", "singleLine": false }, "keys": "ctrl+c" }, { "command": "paste", "keys": "ctrl+v" }, { "command": "find", "keys": "ctrl+shift+f" }, { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" } ], "copyFormatting": "none", "copyOnSelect": false, "defaultProfile": "{f33743eb-6e3b-4d53-8a1e-59a6a567b47c}", "profiles": { "defaults": { "colorScheme": "MaterialOcean", "cursorShape": "filledBox", "font": { "face": "\u66f4\u7eb1\u9ed1\u4f53 Mono SC Nerd" } }, "list": [ { "colorScheme": "MaterialOcean", "commandline": "", "guid": "{f33743eb-6e3b-4d53-8a1e-59a6a567b47c}", "hidden": false, "icon": "D:\\fish.gif", "name": "fish", "startingDirectory": "%USERPROFILE%" }, { "colorScheme": "MaterialOcean", "guid": "{aab79973-318f-43b6-a9bc-b4096493753f}", "hidden": false, "name": "Nushell", "source": "nu" }, { "colorScheme": "MaterialOcean", "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "hidden": false, "name": "Windows PowerShell" }, { "colorScheme": "MaterialOcean", "commandline": "", "guid": "{02d5718b-5b02-4dda-9430-87d047c90533}", "hidden": false, "icon": "ms-appx:///ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.png", "name": "" }, { "colorScheme": "MaterialOcean", "commandline": "", "guid": "{49f5f541-e2cf-4c7c-8ca8-9dfa0b2717fb}", "icon": "ms-appx:///ProfileIcons/{b453ae62-4e3d-5e58-b989-0a998ec441b8}.png", "name": "" } ] }, "schemes": [], "tabSwitcherMode": "mru" }NekoAria commentedon Jul 7, 2022
I withheld some information on privacy reasons.
zadjii-msft commentedon Jul 7, 2022
Hmm. Looks like deleted profiles still show up in the duplicate profile dropdown. That's wild, and sure shouldn't be happening.
Yep, the
AddProfilepage is just handed a whole reference to the settings, and doesn't filter on!IsDeleted(), like the other nav view does.DHowett commentedon Jul 7, 2022
Ah, so deleted profiles are intended to show up in that dropdown. Until we have support for "template" profiles (like, "Terminal detected these -- do you want one of them?"), we have to store them there. Otherwise, there is no way to get them back, for users who have changed their minds.
zadjii-msft commentedon Jul 7, 2022
That's fine by me. I'm gonna call this "by design" then. Maybe not the most clear, but not a bug. If anyone's got good recommendations on ways to make this clearer, feel free to add it in the comments below.