Repository navigation
TerminalApp.Unit.Tests.manifest gets updated when building #12543
Description
Windows Terminal version
Commit 09e9915
Windows build number
10.0.19041.1415
Other Software
No response
Steps to reproduce
- Checkout the latest source (commit 09e9915 or later).
- Build the solution.
- Look for any modified files in git status.
Expected Behavior
There shouldn't be any modified files.
Actual Behavior
The TerminalApp.Unit.Tests.manifest file is being updated with the same changes that were made to the WindowsTerminal.manifest file in PR #12462.
Shouldn't those changes have been committed at the same time as the WindowsTerminal manifest? Or if the unit test manifest is generated automatically, then maybe it shouldn't be committed at all.
Or am I the only one that's getting this?
Activity
zadjii-msft commentedon Feb 21, 2022
What, no, I always build the unit tests.... 😅
I think there's at least one open PR that's got a similar update in it snuck in, but if you'd like to submit a PR just for this tiny bit then that's fine.
Frankly those tests should probably be reworked into the broader localtests or fixed so they don't need to do that anymore, but 🤷
Commit updated TerminalApp.Unit.Tests.manifest file (#12549)