[Terminal]: 'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Settings page. #12424

Activity

1. ghost added

   Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

   on Feb 8, 2022
2. ghost added

   Area-AccessibilityIssues related to accessibilityIssues related to accessibility

   on Feb 8, 2022
3. ghost added

   HCL-E+DAccessibility trackingAccessibility tracking

   on Feb 8, 2022
4. ghost added

   A11yUsableAccessibility trackingAccessibility tracking

   on Feb 8, 2022
5. ghost added

   HCL-WindowsTerminalAccessibility trackingAccessibility tracking

   on Feb 8, 2022
6. ghost added

   A11yCOAccessibility trackingAccessibility tracking

   on Feb 8, 2022
7. ghost added

   Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

   on Feb 8, 2022
8. ghost added

   Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

   on Feb 8, 2022
9. ghost changed the title [-][Terminal]: 'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes.[/-] [+][Terminal]: 'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Settings page.[/+] on Feb 8, 2022
10. Mike Griese (zadjii-msft)

    added

    Area-SettingsUIAnything specific to the SUIAnything specific to the SUI

    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.Complex enough to require an in depth planning process and actual budgeted, scheduled work.

    Priority-3A description (P3)A description (P3)

    and removed

    Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

    on Feb 8, 2022
11. Mike Griese (zadjii-msft)

    added this to the Backlog milestone on Feb 8, 2022
12. Mike Griese (zadjii-msft)

    added

    Product-TerminalThe new Windows Terminal.The new Windows Terminal.

    and removed

    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meetingIt's a new issue that the core contributor team needs to triage at the next triage meeting

    on Feb 8, 2022
13. ghost removed

    Needs-Tag-FixDoesn't match tag requirementsDoesn't match tag requirements

    on Feb 8, 2022
14. carlos-zamora commented on Feb 8, 2022

    

    Carlos Zamora (carlos-zamora)

    on Feb 8, 2022

    More actions

    This depends on #9207. Once that's complete, we can detect if changes have been made, and enable/disable the buttons.

    We probably need to use SettingContainer to detect when a change occurred, and update some global view model property s_ChangesDetected = true.

    Come to think of it, it would be cleaner to do this with MVVM done, but we could just store that static property off of MainPage (or MainPage's new view model, which we then populate more later). That would be a step in the right direction.
15. akash07k commented on Feb 16, 2022

    

    Akash Kakkar (akash07k)

    on Feb 16, 2022

    More actions

    Carlos Zamora (@carlos-zamora) Absolutely.
    MVVM pattern in settings UI will be a lot appreciated.
    It will make the things more flexible

    👍React with 👍1Reacted by Carlos Zamora
16. Dustin L. Howett (DHowett)

    added a commit that references this issue on Aug 23, 2024

    Track and log changes to settings (#17678)

    ...

    0a9cbd0
17. Priyanka-Chauhan123

    added

    WindowsTerminal_Win32

    on Feb 18, 2025