Repository navigation
New terminal does not handle theme change event. #1230
Description
From MSFT:21424988
I have to restart the new terminal to see the effects of changing between light and dark windows theme.
You can see at the attached screenshot that the tabs haven't changed it's colors after I changed from Dark to Light theme. UWP apps are supposed to do that by default.
Reacted by Brandon Fowler, Alexandre Zollinger Chohfi, Mason Kerr, Stefan Scherer, Zachary Yaro, Nikolaus Waxweiler, Scott Bilas, Iván Renison and Sergiu Bacioiu
Activity
DHowett-MSFT commentedon Jun 12, 2019
This one is interesting. We could probably tackle it as part of #1125, but maybe we want to keep it separate?
Aarklendoia commentedon Jun 13, 2019
The window border as well as the area with the Minimize, Maximize and Close buttons does not take the color of the theme (remains white despite the dark theme).
Aarklendoia commentedon Jun 13, 2019
Mercurial commentedon Jun 22, 2019
same here , anyone know how to fix this?
DHowett-MSFT commentedon Jun 22, 2019
To be blunt: somebody needs to write the code to do this. If we do it, it will come out whenever we are done. If we don’t, we will get back to it eventually.
12 remaining items
olegKusov commentedon Jun 7, 2021
Hi , is there any update on fix? How can we get theme auto switching and config for default light and default dark themes ?
zadjii-msft commentedon Jun 7, 2021
Nope. We'll make sure to update this thread when there is. In the meantime, might I recommend the Subscribe button?
☺️
That way you'll be notified of any updates to this thread, without needlessly pinging everyone on this thread
olegKusov commentedon Jun 10, 2021
Hi, thanks for feedback. Is there any dificulties? How can we help? Because for me automatic theme switching is now the basic OS feature. Windows starts to look very outdated after MacOS where I use automatic dark theme in terminal. And issue created 3 years ago. Do you need some help?
j4james commentedon Jun 10, 2021
Given that the issue is labelled "Help Wanted", I think it's safe to assume that's a yes. 😉
If you'd like to help, let the team know that you want to work on the feature, and explain briefly how you intend to implement it. You can find more information in the Contributor's Guide.
zadjii-msft commentedon Jun 10, 2021
Yep, there's no real reason we haven't done this other than simply resourcing. We've only got so many devs, and something like 10,000 issues that have been active since the Terminal was first released 😄
JasonWei512 commentedon Jun 22, 2021
Terminal.on.Win11.mp4
For some reason Windows Terminal 1.8.1521.0 follows system theme on Windows 11, but not on Windows 10.
Use system theme
zadjii-msft commentedon Jan 4, 2022
Huh, that's totally right, this did seemingly get fixed in Windows 11. That seems to me to imply that there was actually just an OS bug that was the actual root cause for this one. I'm gonna close this one out as external - there's maybe something that we could do to fix this on Windows 10, but the fact that an OS fix remedied this makes me think that would be a futile effort.
j4james commentedon Jan 4, 2022
Mike Griese (@zadjii-msft) I actually have a fix for this on Windows 10 which is not that complicated. Is it worth submitting a PR, or would you rather just leave it as is?
zadjii-msft commentedon Jan 4, 2022
James Holderness (@j4james) If you have a fix in hand then go for it! I'm maybe being a little aggressive in closing out some of the older things in the backlog.