Skip to content

Action for adjusting opacity at runtime #11205

Closed

Description

Description of the new feature/enhancement

I love the pane of glass look for Terminal. However, when using a dark theme for example in Terminal and the window is in front-of a light colored windows (i.e. Browser with a white page), the text is unreadable in terminal. And when the Terminal is in front of a dark background the text color in Terminal is nice and crisp. What would be great is if the Terminal can detect the underlying window color and dynamically adjust the opacity to ensure the text of the Terminal window remains readable regardless of the window that Terminal is in front of.

Can't read text in Terminal with transparency in front of a light window when using a dark theme. In order to keep the pane of glass look, I need to keep adjusting the transparency setting based on the background colors (background theme and/or window the Terminal is overlaying). New functionality would automatically adjust this or at a minimum provide a hot key to adjust transparency on demand

Proposed technical implementation details (optional)

Activity

  1. added
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    on Sep 12, 2021
  2. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Sep 12, 2021
  3. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Sep 12, 2021
  4. zadjii-msft commented on Sep 13, 2021

    @zadjii-msft
    Member

    Wow, someone who wants a transparency feature that's not #11180, what a pleasant surprise 😅

    I'm pretty sure there's not a good way for the Terminal to be able to know what the contents of the screen are underneath our window. However:

    or at a minimum provide a hot key to adjust transparency on demand

    Now that's something I can get behind, and something I was already planning for landing once #11180 merged and once I did the control settings refactor for #5000, so I'll leave this open to track that. Thanks!


    edit: pseudo-spec

    • setOpactiy:
      • "opacity": (required) an integer number to set the opacity to.
      • "relative": (defaults to false)
        • If false, set the opacity to the given value, which should be between [0, 100].
        • If true, then use opacity as a relative adjustment to the current opacity. So the implementation would get the current opacity for this pane, then add this action's opacity to that value. Should be between [-100, 100]

    This would allow both setting exactly 25% opacity with an action, and binding an action that increases/decreases the opacity one {amount}

  5. changed the title [-]Dynamic transparency[/-] [+]Action for adjusting opacity at runtime[/+] on Sep 13, 2021
  6. added
    good first issueThis is a fix that might be easier for someone to do as a first contribution
    Help WantedWe encourage anyone to jump in on these.
    Issue-TaskIt's a feature request, but it doesn't really need a major design.
    Area-SettingsIssues related to settings and customizability, for console or terminal
    and removed
    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.
    on Sep 13, 2021
  7. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Sep 13, 2021
  8. removed
    Help WantedWe encourage anyone to jump in on these.
    good first issueThis is a fix that might be easier for someone to do as a first contribution
    on Sep 13, 2021
  9. zadjii-msft commented on Nov 8, 2021

    @zadjii-msft
    Member

    adjust-opacity-preview-001

    dev/migrie/f/11205-adjustOpacity is ready to go, but it's targeting #11619 so I need that reviewed first

  10. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Dec 10, 2021
  11. ghost added
    In-PRThis issue has a related PR
    on Jan 5, 2022
  12. ghost closed this as completedin #12092on Jan 12, 2022
  13. ghost removed
    In-PRThis issue has a related PR
    on Jan 12, 2022
  14. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Jan 12, 2022
  15. ghost added a commit that references this issue on Jan 12, 2022
    c3fd26a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-SettingsIssues related to settings and customizability, for console or terminalIssue-TaskIt's a feature request, but it doesn't really need a major design.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions