Skip to content

[Epic] Admin-specific customizations #11111

Open
0 of 3 issues completed
Open

Description

written and maintained by Carlos Zamora (@carlos-zamora) & Mike Griese (@zadjii-msft)

For quite some time now, we've gotten requests for admin-specific customizations. The first being to have an "appearance config" for an elevated session. However, we stopped working on that when we hit the following problem: how do we determine which appearance config to choose when a user is in an elevated session and also has an unfocused appearance config?

Over time, we've gotten more requests with similar situations (not necessarily limited to appearance config). This epic tracks these requests:


zadjii-msft notes:
Nexus of weird elevate:true bugs:


User stories

  • I want the Terminal to have a different set of profiles in the dropdown when running elevated (vs regularly)
  • I want a different defaultProfile when running elevated
  • I want to use a different profile.defaults block when running elevated
  • I want a profile to have a different appearance when running elevated
  • I want the Terminal itself to have a different theme when running elevated

Open questions

  • Is this prone to a combinatiorial explosion of situational settings? YES IT IS
  • Should these all be in the base settings file, or a separate settings file?
    • IE, should we have
      • elevatedTheme, elevatedDefaultProfile, profiles.elevatedDefaults OR
      • admin-settings.json
    • Should there be a entirely separate globals block for elevated settings, ala Add per-window-name global settings #9992?

Other Admin QoL issues

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Sep 1, 2021
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Sep 1, 2021
  3. added and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Sep 2, 2021
  4. changed the title [-]<camper>[/-] [+][Epic] Admin-specific customizations[/+] on Feb 2, 2023
  5. carlos-zamora commented on Feb 2, 2023

    @carlos-zamora

    We definitely need a spec for this. One fairly extreme idea I had was to introduce an admin-settings.json.

    • if admin-settings.json exists, load that. Otherwise, use settings.json.
    • settings UI modifies the loaded JSON
    • when "import JSON" is eventually a feature in the settings UI, it'll be easier to migrate settings from one settings.json to another

    I'm down for a more clever solution, but it seems like users want a completely customizable experience between their elevated prompt and non-elevated prompt. So might as well enable that experience? Especially since loading a different JSON would be trivial.

  6. zadjii-msft commented on Nov 15, 2024

    @zadjii-msft
    Member

    idea

    "showWhenElevated": false | (true | "both") | "only"

    • false: don't show a profile when elevated
    • true / "both": show this profile both when elevated and when running normally
    • only: Only show this profile when we're running elevated

    Then just screw it with the appearance config on the existing profile - just have two different profiles.
    Maybe when Dustin gets the itch to do separate appearance vs "task"s, then the two profiles could have different appearances, but the same "task".

    this has been thoughts with Luca, who has kept me up since 3am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-SettingsIssues related to settings and customizability, for console or terminalIssue-ScenarioProduct-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions