Skip to content

Settings that are floats like acrylicOpacity don't round trip correctly #11080

Open

Description

Windows Terminal version (or Windows build number)

1.11.2372.0

Other Software

Just a terminal bug, nothing else

Steps to reproduce

Edit settings.json manually and set "acrylicOpacity": 0.7 while Terminal is running.

Now go to the Terminal Settings UI and change something else. Note that acrylicOpacity is now 0.69999999999999996

image

Expected Behavior

I expected floats to roundtrip with JSON numbers

Actual Behavior

0.7 turned into "acrylicOpacity": 0.69999999999999996,

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Aug 30, 2021
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Aug 30, 2021
  3. j4james commented on Aug 30, 2021

    @j4james
    Collaborator

    Technically this is the same issue as #1398. That was initially "fixed" by PR #2475, which simply stopped serializing settings. But I'm assuming the problem returned once we introduced the new Settings UI, so there was a need for the serializing again.

  4. zadjii-msft commented on Sep 8, 2021

    @zadjii-msft
    Member

    Yea, that's probably not right. I wonder what other settings we have that are floats like this. I'm about to blow away acrylicOpacity as a float in #603, but we'll need to do something about the others.

  5. added
    Area-SettingsIssues related to settings and customizability, for console or terminal
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    on Sep 8, 2021
  6. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Sep 8, 2021
  7. removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-SettingsIssues related to settings and customizability, for console or terminalIssue-BugIt either shouldn't be doing this or needs an investigation.Priority-3A description (P3)Product-TerminalThe new Windows Terminal.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions