Initial code export#1
Conversation
daprilik
left a comment
There was a problem hiding this comment.
excited to see this get open sourced!
out of curiosity, has the implementation been run through miri yet? Given the no_std, no dependency nature of the library, it should be pretty easy to do, and would be a great thing to mention in the Readme.
Cargo.toml
Outdated
| version = "0.1.0" | ||
| edition = "2021" | ||
| license = "MIT" | ||
|
|
There was a problem hiding this comment.
not sure if the missing authors field is intentional or not (just thought I'd point it out)
There was a problem hiding this comment.
I wasn't sure what to put for that so I left it blank. I'll add authors = ["Microsoft"] I guess.
| - Remove this section from the README | ||
| # StackFuture | ||
|
|
||
| This crate defines a `StackFuture` wrapper around futures that stores the wrapped future in space provided by the caller. |
There was a problem hiding this comment.
Seems like GitHub markdown doesn't respect newlines between sentences, so if you're particular about formatting, double-check the rendered markdown looks how you expect.
|
LGTM |
I've run |
No description provided.