LooseObjectsStep: simplify code for getting directory paths#218
Merged
Conversation
kewillford
approved these changes
Nov 6, 2019
wilbaker
force-pushed
the
fix_count_loose_objects
branch
from
e97ec7b to
ebb4b0b
Compare
wilbaker
changed the title
The code in CountLooseObjects can be simplified by avoiding an unnecessary Path.Combine. Additionally, fix a bug in the MockFileSystem where EnumerateDirectories was not returning the full paths of directories and it should.
wilbaker
force-pushed
the
fix_count_loose_objects
branch
from
ebb4b0b to
f3ecc5f
Compare
wilbaker
changed the title
Member
Author
|
Waiting a day on #201 before merging. |
derrickstolee
changed the title
derrickstolee
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in CountLooseObjects can be simplified by avoiding
an unnecessary Path.Combine.
Additionally, fix a bug in the MockFileSystem where EnumerateDirectories
was not returning the full paths of directories and it should.
I found this while updating the unit tests as part of #216, the port to VFS4G is here: microsoft/VFSForGit#1570