Remove Scalar.UnitTests.Windows

[wilbaker]

Depends on #4

Once the move to .NET Core is complete, all of the unit tests should be able to live in Scalar.UnitTests as none will required .NET Framework.

[derrickstolee]

The only .Windows or .Mac project to remain are the notifications projects, I believe. @mjcheetham knows more about this.

[mjcheetham]

Once the move to .NET Core is complete, all of the unit tests should be able to live in Scalar.UnitTests as none will required .NET Framework.

Correct, although we'll still probably need some Windows specific tests, or modify the tests to be OS agnostic (things like Path.GetFullPath or .Combine behave differently).

At least in xUnit I know you can make custom test attributes that will mark tests as applicable/not on a given OS. I assume NUnit provides the same functionality.

The only .Windows or .Mac project to remain are the notifications projects, I believe. @mjcheetham knows more about this.

Yes. The Notification.Mac project (an Xcode project) and the Service.UI (which is Windows only).

[wilbaker]

Correct, although we'll still probably need some Windows specific tests, or modify the tests to be OS agnostic (things like Path.GetFullPath or .Combine behave differently).

Most (all?) of the tests that could/should run on all platforms are already doing this, and so I don't think there would be too much work to clean up anything we missed.

At least in xUnit I know you can make custom test attributes that will mark tests as applicable/not on a given OS. I assume NUnit provides the same functionality.

Yep we're able to do the same with NUnit. We've done this in the functional tests by tagging the Windows specific tests as "WindowsOnly" and then having Program.cs include/exclude those tests based on the OS that we're on.

[github-actions]

Labeling this issue as stale. There has been no activity for 30 days. Remove stale label or comment or this issue will be closed in 7 days.

[wilbaker]

Resolved by #201