-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use PackageReference for C++ dependencies #8195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
38de357
3f31bc7
1bac122
7466121
e728e3d
c6dc800
256890d
9785dae
2827453
77d4488
65defd8
3767457
749ce8f
f985c82
92c9011
b02f9b8
ef480e1
ebdfae0
77cb4b4
27c384d
8c8b5cb
19216b2
0a76e63
6bc8547
0e1ca51
0e9ed90
4392c69
4702de6
833ec37
1cac88c
32ff08e
3dc669d
8bb278a
dc76c17
4bd58e7
3841826
cc3a2e8
bf202d8
3fd5a95
78bae0d
ab427d8
94fdcef
8fdc508
1626cb8
d4b3151
5566224
d263c9a
99da255
5ca6703
ca003b2
9753d3e
3b7ac9a
0f80fe8
a02c3e7
07af898
9ef1abf
887993b
83c4ab0
c6064c3
155e118
716eb7d
59f1c4a
dc89edf
9b9aa00
f8289e4
5f2f077
84202be
a3d411c
8fe709b
cf47667
63f5d1a
02bb0e9
ec9487a
4a3d01c
59e2d0f
af601c5
107f13a
99d1e2b
cfa58d0
781e882
482b047
e1700f3
1db8c76
7836ec4
59d2896
83e7a01
e29f325
20618bc
d73b7d6
61850d9
51e0e78
7510a37
af203a6
67e9a69
dbdc48a
45ba52f
3f492a6
5bca403
fe782e8
f004514
65b91c6
2805162
cec5d0c
0a5c72d
f9c470d
fc79827
d3a62b0
65d6f7e
7ed3125
986c152
0577c25
12997c9
cb3b269
8c92d5f
a528038
1c45e60
7128af9
ce2727f
e4c3ce0
8e12e98
1989cf8
6a06e6f
46689e7
08f20a9
4756434
880e4e2
1cf2fe4
45d12da
7ddf83f
79397d1
280f8db
4b06e47
fe4155f
806270d
82a798f
79e1440
b5fae78
7635eb8
37d7336
134b0c8
4e8e7c0
5433e5b
ca18754
b540062
9f31028
9bbb55a
281a663
6f7ddf1
3bd852b
8ff42fc
9d25c63
eb40427
1a93938
910270c
6b7aaa1
011fedb
dfe9c87
29e4fa3
047c86d
6d26510
0581709
6be7d99
ae98f4b
89ffe1d
48e1c96
35eb7a6
60207ab
6aa4b8f
27cb262
0a4ecc6
8e94a57
e538c43
aaa3531
fab1391
673c83e
0f27557
cedbf93
d1c61de
b3b1d55
abbb3fe
519dc53
47a23e2
8130455
cd7b4c2
41f85a4
7144b68
c2ac06d
6a1baac
1093bff
a9e9234
757b679
64153df
9e60c66
9107617
45d717d
2f19611
65d1a97
2f5af0c
08f18c0
60692da
77440ad
51f0faa
0cdacf8
440ded9
9d4c758
7dd9244
1f23e1a
7caf747
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,43 @@ | |
| --> | ||
| <PropertyGroup> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These being at the root of the repo means that none of these props will apply to RNW users, who consume the bits via NuGet or npm. This is dangerous, since it causes developers to get different behavior from users. Do we need to use this props file?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do, so it applies to all projects in the repo and not only the ones under These properties/definitions don't need to be applied to user's code. Consumers of RNW can decide whether they want to use PackageReference-style restore or not. |
||
| <ReactNativeWindowsDir>$(MSBuildThisFileDirectory)vnext\</ReactNativeWindowsDir> | ||
|
|
||
| <Platform Condition="'$(Platform)' == ''">x64</Platform> | ||
| <Configuration Condition="'$(Configuration)' == ''">Debug</Configuration> | ||
|
|
||
| <RootIntDir>$(ReactNativeWindowsDir)build</RootIntDir> | ||
| <RootOutDir>$(ReactNativeWindowsDir)target</RootOutDir> | ||
| <!-- Visual Studio forces using 'Win32' for the 'x86' platform. --> | ||
| <BaseIntDir Condition="'$(Platform)' == 'Win32'">$(RootIntDir)\x86\$(Configuration)</BaseIntDir> | ||
| <BaseIntDir Condition="'$(Platform)' != 'Win32'">$(RootIntDir)\$(Platform)\$(Configuration)</BaseIntDir> | ||
| <BaseOutDir Condition="'$(Platform)' == 'Win32'">$(RootOutDir)\x86\$(Configuration)</BaseOutDir> | ||
| <BaseOutDir Condition="'$(Platform)' != 'Win32'">$(RootOutDir)\$(Platform)\$(Configuration)</BaseOutDir> | ||
|
NickGerleman marked this conversation as resolved.
|
||
| </PropertyGroup> | ||
|
|
||
| </Project> | ||
| <PropertyGroup Label="NuGet"> | ||
| <MSBuildProjectExtensionsPath Condition="'$(ProjectName)' != ''">$(RootIntDir)\ProjectExtensions\$(ProjectName)\</MSBuildProjectExtensionsPath> | ||
| <MSBuildProjectExtensionsPath Condition="'$(ProjectName)' == ''">$(RootIntDir)\ProjectExtensions\$(MSBuildProjectName)\</MSBuildProjectExtensionsPath> | ||
|
JunielKatarn marked this conversation as resolved.
|
||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Label="NuGet" Condition="'$(MSBuildProjectExtension)' == '.vcxproj'"> | ||
|
|
||
| <!-- https://github.com/NuGet/Home/issues/10511#issuecomment-778400668 --> | ||
| <AssetTargetFallback>$(AssetTargetFallback);native</AssetTargetFallback> | ||
|
|
||
| <!-- | ||
| Avoid Visual Studio error message: | ||
| "The project '$(MSBuildProjectName)' ran into a problem during the last operation: The value of the | ||
| 'TargetFrameworkMoniker' and 'NuGetTargetMoniker' properties in the '$(Configuration)|$(Platform)' configuration are both | ||
| empty. This configuration will not contribute to NuGet restore, which may result in restore and build errors. You may | ||
| need to reload the solution after fixing the problem." | ||
| --> | ||
| <TargetFrameworkMoniker>native,Version=v0.0</TargetFrameworkMoniker> | ||
| <!-- TODO: Keep? --> | ||
| <!-- <RuntimeIdentifiers Condition="'$(RuntimeIdentifiers)' == ''">win;win-x64;win-x86;win-arm64</RuntimeIdentifiers> --> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Label="NuGet" Condition="'$(MSBuildProjectExtension)' == '.vcxproj'"> | ||
| <ProjectCapability Include="PackageReferences" /> | ||
|
JunielKatarn marked this conversation as resolved.
|
||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Use PackageReference in C++ projects", | ||
| "packageName": "@react-native-windows/automation-channel", | ||
| "email": "julio.rocha@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Use PackageReference for C++ dependencies", | ||
| "packageName": "@react-native-windows/cli", | ||
| "email": "julio.rocha@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Use PackageReference for C++ dependencies", | ||
| "packageName": "node-rnw-rpc", | ||
| "email": "julio.rocha@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Use PackageReference for NuGet Dependencies", | ||
| "packageName": "react-native-windows", | ||
| "email": "julio.rocha@microsoft.com", | ||
| "dependentChangeType": "none" | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.