Skip to content

fix(cli): parse negative numbers as arguments #42333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 2 commits into from
Aug 20, 2026
+15 −2
Merged

fix(cli): parse negative numbers as arguments #42333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b4f70c
fix(cli): parse negative numbers as arguments
yury-s Aug 20, 2026
3fe7b83
test(cli): make the negative number test browser-independent
yury-s Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/playwright-core/src/tools/cli-client/minimist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ export function minimist(args: string[], opts?: MinimistOptions): MinimistArgs {
} else {
setArg(key, strings[key] ? '' : true);
}
} else if ((/^-[^-]+/).test(arg)) {
} else if ((/^-[A-Za-z]/).test(arg)) {
// Short flags are letters, so '-100' and '-.5' are arguments, not flags.
const letters = arg.slice(1, -1).split('');

let broken = false;
Expand Down
14 changes: 13 additions & 1 deletion tests/mcp/cli-parsing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import { test, expect } from './cli-fixtures';
import { test, expect, eventsPage } from './cli-fixtures';

test('unknown option', async ({ cli, server }) => {
const { error, exitCode } = await cli('open', '--some-option', 'value', 'about:blank');
Expand Down Expand Up @@ -73,6 +73,18 @@ test('wrong argument type', async ({ cli, server }) => {
expect(press.exitCode).toBe(0);
});

test('negative number arguments', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/42321' } }, async ({ cli, server }) => {
server.setContent('/', eventsPage, 'text/html');
await cli('open', server.PREFIX);
await cli('mousemove', '50', '50');

expect((await cli('mousewheel', '0', '-100')).exitCode).toBe(0);
await expect.poll(() => cli('snapshot').then(result => result.inlineSnapshot)).toContain('wheel 0 -100');

const { error } = await cli('mousewheel', '-.5');
expect(error).toContain(`error: 'dy' argument: expected number, received 'undefined'`);
});

test('should preserve leading zeros in string arguments', async ({ cli, server }) => {
server.setContent('/', `<input type=text>`, 'text/html');
await cli('open', server.PREFIX);
Expand Down
Loading