fix(glob): treat unbalanced braces as literals in globToRegexPattern - #40558
Closed
pieter (importpieter) wants to merge 1 commit into
Closed
fix(glob): treat unbalanced braces as literals in globToRegexPattern#40558pieter (importpieter) wants to merge 1 commit into
pieter (importpieter) wants to merge 1 commit into
Conversation
An unmatched '{' emitted an unclosed regex group '(' and an unmatched
'}' emitted an unmatched ')'. Both produce SyntaxError at match time,
silently aborting the intercepted request with ERR_ABORTED.
Fix: look ahead for a closing '}' before emitting the group opener, and
only close the group when we are actually inside one.
Fixes: microsoft/playwright#40422
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Closing in favour of #40442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{emitted an unclosed regex group(, and an unmatched}emitted an unmatched)— both produceSyntaxErrorwhen the regex is compiled at match time, silently aborting the intercepted request withERR_ABORTED}before emitting the group opener; only close the group when actually inside oneFixes #40422