test(mcp): tear down daemons spawned via cli --json in fixture teardown - #40352
Merged
Simon Knott (Skn0tt) merged 1 commit intoApr 22, 2026
Merged
Conversation
The cli fixture extracted the daemon pid from the text-mode marker
`### Browser \`X\` opened with pid N.` only. When tests invoke
`cli('--json', 'open', ...)`, the marker is absent and the daemon
leaked past the test as an orphan process (visible in CI logs as
"Terminate orphan process" lines).
Fall back to parsing the --json envelope's `pid` field so the
teardown loop reaps the daemon regardless of output mode.
Contributor
Test results for "MCP"5 failed 6560 passed, 910 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clitest fixture extracts the daemon pid from the text-mode marker### Browser \X` opened with pid N.to reap it in teardown. Tests usingcli('--json', 'open', ...)` (added in feat(cli): add --json global flag for structured output #40284) get no such marker, so the daemon survives the test as an orphan process — visible in CI as "Terminate orphan process" entries at the end of MCP jobs (example: https://github.com/microsoft/playwright/actions/runs/24770691947/job/72476069241#step:7:2).--jsonenvelope'spidfield so the teardown loop works regardless of output mode.