Skip to content

C entrypoint fixes#2421

Merged
brianrob merged 2 commits into
microsoft:mainfrom
zachcmadsen:c-entrypoint-fixes
May 18, 2026
Merged

C entrypoint fixes#2421
brianrob merged 2 commits into
microsoft:mainfrom
zachcmadsen:c-entrypoint-fixes

Conversation

@zachcmadsen

Copy link
Copy Markdown
Contributor

A couple fixes related to microsoft/one-collect#268:

  • Recognize <module>!_start as a valid top frame
  • Bump symbol length by one for dynamic symbols to catch addresses on the symbol end boundary. _start seems to be a pathological case

With the one-collect change and these fixes we get a complete stack:

+ Process32 workload (140228) Args: workload
 + Thread (140228) CPU=19984ms
  + workload!_start
  |+ libc.so.6!__libc_start_main
  | + libc.so.6!__libc_start_call_main
  |  + workload!main
  |   + workload!run_workload
  |    + workload!hot_loop
  |    + workload!warm_loop
  |    + workload!cold_loop

@zachcmadsen zachcmadsen requested a review from a team as a code owner May 15, 2026 14:23
@zachcmadsen

Copy link
Copy Markdown
Contributor Author

Cc @brianrob

@brianrob brianrob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zachcmadsen!

@brianrob brianrob merged commit 2f3a001 into microsoft:main May 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants