Skip to content

Dispose WebView2 controls before Environment.Exit to prevent finalizer crash #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianrob merged 1 commit into from
Feb 27, 2026
Merged

Dispose WebView2 controls before Environment.Exit to prevent finalizer crash #2371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/PerfView/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,17 @@ private void Window_Closed(object sender, EventArgs e)
// DO NOT call Environment.Exit(0) under tests, it will kill the test runner, and tests won't complete.
if (!_testing)
{
// Dispose all WebView2 browser controls before exiting. Environment.Exit triggers
// finalizers, and the WebView2 finalizer crashes if the underlying COM objects have
// already been torn down during process shutdown.
foreach (Window window in Application.Current.Windows)
{
if (window is WebBrowserWindow browserWindow)
{
browserWindow.Browser?.Dispose();
}
}

Environment.Exit(0);
}
}
Expand Down