Skip to content

Fix clipboard copy formatting based on selection dimensions in Stack Viewer #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianrob merged 8 commits into from
Jan 15, 2026
Merged

Fix clipboard copy formatting based on selection dimensions in Stack Viewer #2332

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c40f773
Initial plan
Copilot Nov 13, 2025
2cc6f15
Fix clipboard copy for single cell to exclude markdown formatting
Copilot Nov 13, 2025
a07effc
Fix markdown formatting for vertically stacked cell selections
Copilot Nov 14, 2025
afbc9d4
Implement proper clipboard formatting based on selection dimensions
Copilot Nov 14, 2025
079946b
Add pipes for multiple columns and special First/Last handling
Copilot Jan 12, 2026
2bb092a
Fix missing newline for 2-cell single column selections
Copilot Jan 13, 2026
2b68cf2
Remove GitHub reference from markdown table comment
Copilot Jan 13, 2026
11214cf
Code Review Feedback
brianrob Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 99 additions & 24 deletions src/PerfView/StackViewer/PerfDataGrid.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,14 @@ public PerfDataGrid()
InitializeComponent();
Grid.CopyingRowClipboardContent += delegate (object sender, DataGridRowClipboardEventArgs e)
{
for (int i = 0; i < e.ClipboardRowContent.Count; i++)
// Add markdown table formatting (| symbols) when:
// - Multiple columns selected (except First/Last special case)
// Don't add pipes for: single column or First/Last special case
bool shouldAddPipes = (m_numSelectedColumns > 1 && !m_isFirstLastSelection);

for (int columnIndex = 0; columnIndex < e.ClipboardRowContent.Count; columnIndex++)
{
var clipboardContent = e.ClipboardRowContent[i];
var clipboardContent = e.ClipboardRowContent[columnIndex];

string morphedContent = null;
if (e.IsColumnHeadersRow)
Expand Down Expand Up @@ -60,19 +65,22 @@ public PerfDataGrid()
// Pad so that pasting into a text window works well.
if (e.ClipboardRowContent.Count > 1 && !NoPadOnCopyToClipboard)
{
morphedContent = PadForColumn(morphedContent, i + e.StartColumnDisplayIndex);
morphedContent = PadForColumn(morphedContent, columnIndex + e.StartColumnDisplayIndex);
}

// Add a leading | character to the first column to ensure GitHub renders the content as table
if (i == 0)
{
morphedContent = "| " + morphedContent;
}

// Add a trailing | character to the last column to complete the markdown table row
if (i == e.ClipboardRowContent.Count - 1)
if (shouldAddPipes)
{
morphedContent = morphedContent + " |";
// Add a leading | character to the first column for markdown table format
if (columnIndex == 0)
{
morphedContent = "| " + morphedContent;
}

// Add a trailing | character to the last column to complete the markdown table row
if (columnIndex == e.ClipboardRowContent.Count - 1)
{
morphedContent = morphedContent + " |";
}
}

// TODO Ugly, morph two cells on different rows into one line for the correct cut/paste experience
Expand All @@ -92,7 +100,7 @@ public PerfDataGrid()
return;
}
}
e.ClipboardRowContent[i] = new DataGridClipboardCellContent(clipboardContent.Item, clipboardContent.Column, morphedContent);
e.ClipboardRowContent[columnIndex] = new DataGridClipboardCellContent(clipboardContent.Item, clipboardContent.Column, morphedContent);
}
};

Expand Down Expand Up @@ -520,27 +528,90 @@ private void SelectedCellsChanged(object sender, SelectedCellsChangedEventArgs e
{
// We don't want the header for single values, or for 2 (for cutting and pasting ranges).
int numSelectedCells = window.SelectedCellsChanged(sender, e);
if (numSelectedCells <= 2)
m_numSelectedCells = numSelectedCells;

// Calculate the number of unique columns and rows selected
DataGrid dataGrid = sender as DataGrid;
if (dataGrid != null && dataGrid.SelectedCells.Count > 0)
{
if (numSelectedCells == 2)
var uniqueColumns = new HashSet<DataGridColumn>();
var uniqueRows = new HashSet<object>();
var columnNames = new HashSet<string>();
foreach (var cell in dataGrid.SelectedCells)
{
var dataGrid = sender as DataGrid;
if (dataGrid != null)
uniqueColumns.Add(cell.Column);
uniqueRows.Add(cell.Item);
// Get the column name
if (cell.Column.Header is TextBlock header)
{
var cells = dataGrid.SelectedCells;
if (cells != null)
{
m_clipboardRangeStart = GetCellStringValue(cells[0]);
m_clipboardRangeEnd = GetCellStringValue(cells[1]);
}
columnNames.Add(header.Name);
}
}
Grid.ClipboardCopyMode = DataGridClipboardCopyMode.ExcludeHeader;
m_numSelectedColumns = uniqueColumns.Count;
m_numSelectedRows = uniqueRows.Count;

// Detect special case: 1 row, 2 columns, and they are FirstColumn and LastColumn
Comment thread
marklio marked this conversation as resolved.
// The last two columns in the grid are "First" and "Last" which represent the time range. It's very common
// for users to select these two and copy them so that they can be used to filter the data in this or another view.
// When a user does this, we don't want to add headers or '|' symbols and display as a markdown table. We detect
// this scenario here because markdown support is added in the CopyingRowClipboardContent event handler where we don't
// have access to the column names.
m_isFirstLastSelection = (m_numSelectedRows == 1 && m_numSelectedColumns == 2 &&
columnNames.Contains("FirstColumn") && columnNames.Contains("LastColumn"));
}
else
{
m_numSelectedColumns = 0;
m_numSelectedRows = 0;
m_isFirstLastSelection = false;
}

// Determine whether to include headers based on selection:
// - Single cell: no header
// - First/Last special case: no header
// - Single column, multiple cells: include header
// - Multiple columns, single row: include header (unless First/Last case)
// - Multiple columns, multiple rows: include header
bool shouldIncludeHeader = false;
if (numSelectedCells == 1 || m_isFirstLastSelection)
{
// Single cell or First/Last special case: no header
shouldIncludeHeader = false;
}
else if (m_numSelectedColumns == 1 && m_numSelectedRows > 1)
{
// Single column, multiple rows: include header
shouldIncludeHeader = true;
}
else if (m_numSelectedColumns > 1)
{
// Multiple columns: include header
shouldIncludeHeader = true;
}

if (shouldIncludeHeader)
{
Grid.ClipboardCopyMode = DataGridClipboardCopyMode.IncludeHeader;
}
else
{
Grid.ClipboardCopyMode = DataGridClipboardCopyMode.ExcludeHeader;
}

// Only set range values for the First/Last special case
// This enables the special morphing logic that combines them on one line
if (m_isFirstLastSelection && numSelectedCells == 2)
{
if (dataGrid != null)
{
var cells = dataGrid.SelectedCells;
if (cells != null)
{
m_clipboardRangeStart = GetCellStringValue(cells[0]);
m_clipboardRangeEnd = GetCellStringValue(cells[1]);
}
}
}
}
m_maxColumnInSelection = null;
}
Expand All @@ -559,6 +630,10 @@ private void DoHyperlinkHelp(object sender, System.Windows.RoutedEventArgs e)
/// </summary>
private string m_clipboardRangeStart;
private string m_clipboardRangeEnd;
private int m_numSelectedCells;
private int m_numSelectedColumns;
private int m_numSelectedRows;
private bool m_isFirstLastSelection;
private int[] m_maxColumnInSelection;
private int m_FindEnd;
private Regex m_findPat;
Expand Down