-
Notifications
You must be signed in to change notification settings - Fork 771
Warn users when circular buffer overflow causes missing type info in allocation views for selected processes #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5a4ef1c
Initial plan
Copilot 3f655a6
Add warning for missing type information in allocation views
Copilot 9d7cfc1
Address code review feedback: use ClrTraceEventParser.ProviderGuid an…
Copilot d1126c9
Minor improvements: use == for string comparison and improve bullet p…
Copilot e74a2dc
Address PR review feedback: simplify warning message text
Copilot b66c972
Remove additional sentence from warning message per review feedback
Copilot 40633bd
Refactor to check RuntimeStart per selected process with new OnStackW…
Copilot 0334bec
Complete OnStackWindowLaunch Pattern and Adjust
brianrob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hardcoding is pretty rough. There are a lot of individual strings of things like "GC Heap Net Mem" in the codebase. It would be nice if these were some kind of
SourceKindenum that translated to this string instead of hardcoding everywhere, but that's a change or topic for another day.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a fair point. I'll think on this one.