Dockerfiles for TensorRT, CUDA, build from source - #922
Merged
George Wu (jywu-mysoft) merged 16 commits intoJul 9, 2019
Conversation
Vinitra Swamy (vinitra-zz)
commented
Apr 26, 2019
Vinitra Swamy (vinitra-zz)
commented
- Restructuring dockerfile README
- Adding 3 dockerfiles used for AzureML BYOC scenario
Vinitra Swamy (vinitra-zz)
requested review from
George Wu (jywu-mysoft) and
manashgoswami (manashgoswami)
April 26, 2019 19:48
manashgoswami (manashgoswami)
previously approved these changes
Apr 26, 2019
George Wu (jywu-mysoft)
suggested changes
Apr 29, 2019
George Wu (jywu-mysoft)
left a comment
George Wu (jywu-mysoft)
left a comment
Contributor
There was a problem hiding this comment.
Hector Li (@HectorSVC) and I left some additional review comments on how to optimize further.
Thanks!
…o docker-mcr-update
…o docker-mcr-update
Vinitra Swamy (vinitra-zz)
requested review from
Hector Li (HectorSVC) and
Harry Yang (tianchijushi)
and removed request for
George Wu (jywu-mysoft)
July 2, 2019 17:12
Author
|
Hi @jywu-msft! Addressed your comments in the latest update. Should we include the onnx package as part of the docker image? As of now it only contains the onnxruntime build. |
Contributor
shouldn't need onnx package. |
George Wu (jywu-mysoft)
approved these changes
Jul 9, 2019
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.