Update the GraphProto for subgraphs when saving the Graph. - #647
Merged
Scott McKay (skottmckay) merged 7 commits intoOct 23, 2019
Merged
Conversation
…quired to produce a valid overall Graph if the Graph has been optimized.
Scott McKay (skottmckay)
requested a review
from Konstantinos Karanasos (kkaranasos)
May 25, 2019 03:12
| if (update_subgraphs && attribute.second.has_g()) { | ||
| // partitioning or optimization may have changed the subgraph, so the original GraphProto may not be valid. | ||
| // call ToGraphProto to get the current info and use this for the attribute | ||
| const auto& latest = attr_to_subgraph_map_.find(attribute.first)->second->ToGraphProto(); |
Contributor
There was a problem hiding this comment.
Can we know when the subgraph proto needs re-building, so that we avoid it otherwise?
Contributor
Author
There was a problem hiding this comment.
ToGraphProto only rebuilds if it has to. If there have been no changes it will return the currrent GraphProto instead of creating a new one.
Dmitri Smirnov (yuslepukhin)
deleted the
skottmckay/UpdateSubgraphsWhenSavingGraph
branch
August 6, 2019 17:03
Dmitri Smirnov (yuslepukhin)
restored the
skottmckay/UpdateSubgraphsWhenSavingGraph
branch
August 6, 2019 17:14
Konstantinos Karanasos (kkaranasos)
approved these changes
Oct 8, 2019
…bgraphsWhenSavingGraph
…ithub.com/Microsoft/onnxruntime into skottmckay/UpdateSubgraphsWhenSavingGraph
Weixing Zhang (weixingzh)
approved these changes
Oct 23, 2019
Weixing Zhang (weixingzhang)
approved these changes
Oct 23, 2019
Scott McKay (skottmckay)
deleted the
skottmckay/UpdateSubgraphsWhenSavingGraph
branch
October 24, 2019 20:33
Jaskaran Singh Nagi (jnagi-intel)
pushed a commit
to jnagi-intel/onnxruntime
that referenced
this pull request
Jan 5, 2026
* Fix the LUID check * Address review comments
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes Copy DistributedOnnxModel generated models to output folder. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [x] Format your code by running `pre-commit run --all-files` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to produce a valid overall Graph if the Graph has been optimized. If the GraphProto attribute are not updated
a) the optimizations will be lost from any subgraphs
b) implicit inputs to the subgraphs may be broken by changes to nodes in the parent graph