use LOAD_WITH_ALTERED_SEARCH_PATH for LoadLibraryExA - #3908
Merged
Conversation
George Wu (jywu-mysoft)
requested review from
Ryan Hill (RyanUnderhill) and
Pranav Sharma (pranavsharma)
May 12, 2020 00:45
Pranav Sharma (pranavsharma)
approved these changes
May 12, 2020
Ryan Hill (RyanUnderhill)
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous use of LOAD_WITH_ALTERED_SEARCH_PATH requires absolute paths.
this required us to change the custom op shared lib test case for windows.
using LOAD_WITH_ALTERED_SEARCH_PATH allows for both absolute paths and filenames (falling back to default search paths) to work.