Load provider shared libraries relative to core runtime executable - #3884
Merged
Ryan Hill (RyanUnderhill) merged 3 commits intoMay 10, 2020
Conversation
Ryan Hill (RyanUnderhill)
requested review from
George Wu (jywu-mysoft) and
Pranav Sharma (pranavsharma)
May 9, 2020 00:49
Contributor
|
Thanks! tested locally and it works. |
George Wu (jywu-mysoft)
previously approved these changes
May 9, 2020
| lib_name = "libcustom_op_library.dylib"; | ||
| #else | ||
| lib_name = "./libcustom_op_library.so"; | ||
| lib_name = "./libcustom_op_library.so"; |
Contributor
There was a problem hiding this comment.
If we agree that absolute paths is the way to go, we should be consistent for all platforms and document this? Can be a separate PR perhaps.
Contributor
Author
There was a problem hiding this comment.
Yeah, I have another bug about unloading custom op libraries so I'll address it there.
George Wu (jywu-mysoft)
approved these changes
May 10, 2020
stevenlix (stevenlix)
pushed a commit
that referenced
this pull request
May 12, 2020
…3884) * Load provider DLL relative to core runtime executable * Use LoadLibraryEx to fix dependent DLL loading * Fix custom op DLL loading path issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Uses the path of the core runtime executable/shared library to load the provider shared library.
Motivation and Context
When our core code is loaded by other modules (like python), the core code is not part of the DLL search path on windows and providers will fail to load. This ensures they are loaded from the right place.