Fix C# log APIs. Also fixes github issue #3409. - #3840
Merged
Conversation
Scott McKay (skottmckay)
previously approved these changes
May 6, 2020
Pranav Sharma (pranavsharma)
force-pushed
the
fix_csharp
branch
from
May 6, 2020 20:17
7e7c6fb to
3bae36e
Compare
Pranav Sharma (pranavsharma)
changed the title
…the failed test in case of crash.
Pranav Sharma (pranavsharma)
force-pushed
the
fix_csharp
branch
from
May 8, 2020 07:57
1c3580d to
46c703b
Compare
Hariharan Seshadri (hariharans29)
approved these changes
May 8, 2020
stevenlix (stevenlix)
pushed a commit
that referenced
this pull request
May 12, 2020
* Fix C# log APIs. Fixes github issue #3409. * Fix build error due to accidental duplication of GraphOptimizationLevel * Fix runoptions * Fix broken test. Add --blame switch to dotnet test cmd line to print the failed test in case of crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Fix C# log APIs. Also fixes github issue #3409.
Motivation and Context
#3409