Re-enable Dropout(12) ONNX inferencing tests. - #3833
Merged
Conversation
Thiago Crepaldi (thiagocrepaldi)
previously approved these changes
May 5, 2020
Thiago Crepaldi (thiagocrepaldi)
left a comment
Thiago Crepaldi (thiagocrepaldi)
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Are these tests related to the discussion on whether to increase tolerance or implement a custom verification function? It doesnt seem to be the case, but just checking
Member
Author
|
Thiago Crepaldi (@thiagocrepaldi) Thanks for the review. No these aren’t related to flaky tests. These are ONNX tests. |
…o codemzs/dropout_test
M. Zeeshan Siddiqui (codemzs)
changed the title
M. Zeeshan Siddiqui (codemzs)
changed the title
George Wu (jywu-mysoft)
approved these changes
May 10, 2020
stevenlix (stevenlix)
pushed a commit
that referenced
this pull request
May 12, 2020
* Re-enable disabled Dropout(12) inferencing tests. * Re-enable disabled Dropout(12) inferencing tests. * Disable Dropout(12) tests that return boolean value on NGraph EP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enable Dropout(12) ONNX inferencing tests on all execution providers except
NGraphEP where Dropout ONNX tests that returnbooleantype mask don't seem to work because of below error message:EP_FAIL : Non-zero status code returned while running NGRAPHCustomOp_100 node. Name:'NGRAPHExecutionProvider_NGRAPHCustomOp_100_0' Status Message: [NGRAPHCustomOp] - NGRAPHExecutionProvider_NGRAPHCustomOp_100_0 - Exception while importing model to nGraph: deque::_M_range_check: __n (which is 0)>= this->size()