Fix homepage carousel keyboard accessibility - #32180
Merged
Sunghoon Choi (hanbitmyths) merged 2 commits intoAug 21, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Wayne (Wayne-Ch)
requested review from
Sunghoon Choi (hanbitmyths)
and removed request for
Sunghoon Choi (hanbitmyths)
August 20, 2026 00:32
Contributor
There was a problem hiding this comment.
Pull request overview
Improves homepage carousel keyboard accessibility and adds regression validation.
Changes:
- Uses deterministic semantic links with hidden visual duplicates.
- Pauses and resets animation during keyboard focus.
- Adds built-homepage accessibility tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/carousel-accessibility.test.mjs |
Validates semantic links and hidden copies. |
src/routes/components/customers.svelte |
Makes customer order deterministic. |
src/lib/components/ui/InfiniteMovingCards/InfiniteMovingCards.svelte |
Implements accessible focus and duplication behavior. |
package.json |
Adds the carousel test command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Sunghoon Choi (hanbitmyths)
August 20, 2026 20:36
View session
eserscor
previously approved these changes
Aug 20, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sunghoon Choi (hanbitmyths)
approved these changes
Aug 21, 2026
Sunghoon Choi (hanbitmyths)
deleted the
wayne-ch-fix-carousel-accessibility
branch
August 21, 2026 22:29
Wayne (Wayne-Ch)
added a commit
that referenced
this pull request
Aug 22, 2026
## Description Replace the obsolete `doxygen.nl` download URL for the pinned Doxygen 1.9.8 Linux binary with the official asset from the Doxygen GitHub release tag `Release_1_9_8`. The C API docs workflow has persistently failed while downloading Doxygen (runs [31917039689](https://github.com/microsoft/onnxruntime/actions/runs/31917039689), [31975339915](https://github.com/microsoft/onnxruntime/actions/runs/31975339915), and [32050624667](https://github.com/microsoft/onnxruntime/actions/runs/32050624667)). Because no fresh `onnxruntime-c-apidocs` artifact was produced before the previous artifact expired, the downstream ONNX Publish site run [32533178465](https://github.com/microsoft/onnxruntime/actions/runs/32533178465) failed at `Download C apidocs artifact`, blocking GitHub Pages deployment. This is intentionally separate from accessibility PR #32180. ## Validation - Confirmed the official release URL follows one redirect and returns HTTP 200. - Confirmed GitHub release tag `Release_1_9_8` contains `doxygen-1.9.8.linux.bin.tar.gz` (50,500,806 bytes). - Downloaded the archive successfully and verified gzip/tar integrity. - Confirmed extraction produces `doxygen-1.9.8/bin/doxygen` while preserving the workflow's existing extraction and invocation paths. - Parsed the workflow as valid YAML. - Dispatched the [C/C++ API docs workflow from this branch](https://github.com/microsoft/onnxruntime/actions/runs/32534100983); the install, Doxygen generation, and site staging steps succeeded, and the log reports `Doxygen version used: 1.9.8`. Artifact upload was skipped as expected because the ref is not `main`. ## Recovery after merge 1. Dispatch the **Update C/C++ API Docs** workflow on `main`. 2. Verify it uploads a fresh `onnxruntime-c-apidocs` artifact. 3. Rerun the failed GitHub Pages jobs from ONNX Publish site run 32533178465. No Doxygen version or unrelated workflow behavior is changed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloneNodecarousel duplication with one semantic customer-link set and anaria-hidden,tabindex="-1"visual copyOfficial production evidence
Accessibility Insights for Web v2.47.0 (axe-core 4.11.3), official Edge Add-ons package:
FastPass_20260819_ONNXRuntimeHome.htmlONNXRuntimeHome-AccessibilityInsights-FastPass-official.zipThis PR validates the fix on a local built preview only. Production must be rerun with the official Accessibility Insights extension after deployment, and ADO 97172 must remain open until both production Tab stops checks pass.
Validation
npm run test:carousel-accessibility(production build plus 2 focused regressions)prefers-reduced-motion: reducedisables animationnpm run checkremains blocked by 38 pre-existing diagnostics in unrelatedsvelte-iconsimports andinference-table.svelte; the changed carousel files report no diagnostics