Fix stale ContribOperators.md for MRotaryEmbedding - #31985
Merged
Tianlei Wu (tianleiwu) merged 1 commit intoAug 12, 2026
Merged
Conversation
The checked-in doc contained '(or omitting it) reduces this op to standard RoPE' but the schema in bert_defs.cc (and the generator output) says 'reduces this op to standard RoPE' — without the parenthetical. mrope_section is a required attribute so the phrase was also semantically incorrect. This was introduced in microsoft#31728 (e415ef9) and causes the 'Windows GPU Kernel Documentation Validation' CI check to fail on every PR merged to main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Justin Chu (justinchuby)
marked this pull request as ready for review
August 11, 2026 20:13
Tianlei Wu (tianleiwu)
approved these changes
Aug 12, 2026
Danny On The Air (dannyota)
added a commit
to dannyota/onnxruntime
that referenced
this pull request
Aug 12, 2026
Picks up the ContribOperators.md regeneration (microsoft#31985), which fixes the Windows GPU Kernel Documentation Validation failure. That check was failing on main independently of this branch. The Go binding CI wiring in linux_ci.yml and reusable_linux_build.yml auto-merged cleanly and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/ContribOperators.mddisagrees with the schema that generates it for theMRotaryEmbeddingoperator, causing the Windows GPU Kernel Documentation Validation CI check to fail on every PR merged tomain.Root cause
PR #31728 (
e415ef9afd) added the fusedMRotaryEmbeddingcontrib op. The checked-in doc contains:but the schema in
onnxruntime/core/graph/contrib_ops/bert_defs.cc(and correspondingly the output ofgen_contrib_doc.py) says:The parenthetical
(or omitting it)is also semantically incorrect —mrope_sectionis declared as a required attribute (AttributeProto::INTSwith no default), so it cannot be omitted.Fix
Remove the inaccurate parenthetical from the checked-in doc to match the schema/generator output.
This is a hand-edit matching exactly what the generator (
tools/ci_build/gen_contrib_doc.py --domains com.microsoft) produces. I did not run the generator because it requires built Python bindings.Impact
Unblocks the documentation validation CI check for all open PRs targeting
main.