ICM fixes (3/n) - #27925
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Hariharan Seshadri (hariharans29)
April 1, 2026 05:43
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an additional security-related ICM item in the Whisper tooling by removing a shell-based command execution path in whisper_jump_times.py, aligning it with the safer approach taken in the earlier validate_package.py fix.
Changes:
- Replace
os.system("pip install ninja")withsubprocess.run([...], check=True)to avoid shell invocation. - Invoke pip via
sys.executable -m pipfor a more reliable interpreter/environment match.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hariharan Seshadri (hariharans29)
requested a review
from Tianlei Wu (tianleiwu)
April 8, 2026 23:09
Tianlei Wu (tianleiwu)
approved these changes
Apr 9, 2026
Tianlei Wu (tianleiwu)
left a comment
Contributor
There was a problem hiding this comment.
No findings from my review. Switching the fallback from os.system("pip install ninja") to subprocess.run([sys.executable, "-m", "pip", "install", "ninja"], check=True) removes shell invocation, uses the active interpreter consistently, and makes installation failures explicit.
Hariharan Seshadri (hariharans29)
merged commit Apr 9, 2026
3fad293
into
main
108 of 111 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix ICM issue: https://portal.microsofticm.com/imp/v5/incidents/details/31000000567822/summary
The ICM is mainly about 2 issues in
validate_package.pywhich was fixed by #27840.But the ICM also references another issue in
whisper_jump_times.pywhich is what this PR fixesMotivation and Context
ICM fixes