[node] remove incorrect error check - #26467
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes a defunct API initialization check from the Node.js binding initialization code. The removed check attempted to verify ONNX Runtime API initialization but was ineffective due to checking the address of a reference rather than a pointer.
- Removes an ineffective null-check for the ONNX Runtime API
- Simplifies the initialization flow by removing unreachable error handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yulong Wang (fs-eire)
enabled auto-merge (squash)
November 1, 2025 17:49
snnn (snnn)
reviewed
Nov 3, 2025
snnn (snnn)
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove the code that generates warning.