Import Featurizers - #2643
Merged
Dmitri Smirnov (yuslepukhin) merged 18 commits intoDec 14, 2019
Merged
Conversation
added 14 commits
December 4, 2019 17:57
Meanwhile investigate if we can do it wo a submodule.
Do not build FeaturizersLibrary for centos CI.
Make sure we do not compile automl_defs when automl is disabled.
…icrosoft/onnxruntime into yuslepukhin/import_featurizers
Dmitri Smirnov (yuslepukhin)
requested review from
David Brownell (davidbrownellWork) and
Changming Sun (snnn)
December 12, 2019 19:22
Dmitri Smirnov (yuslepukhin)
marked this pull request as ready for review
December 12, 2019 19:51
Dmitri Smirnov (yuslepukhin)
force-pushed
the
yuslepukhin/import_featurizers
branch
from
December 13, 2019 01:36
759eb29 to
7b4d8b3
Compare
Comment on lines
+19
to
+20
| GIT_TAG ${ngraph_TAG} | ||
| # Need this to properly checkout crlf |
Contributor
Author
There was a problem hiding this comment.
Good catch! May be that's the reason for some troubles.
In reply to: 357837997 [](ancestors = 357837997)
| INSTALL_COMMAND "" | ||
| ) | ||
| endif() | ||
|
|
Contributor
There was a problem hiding this comment.
Just wondering, does the lib has any C++ types in its public interface?
Contributor
Author
There was a problem hiding this comment.
Well, they are not public outisde ORT. ORT consumes this library.
In reply to: 357838315 [](ancestors = 357838315)
Changming Sun (snnn)
approved these changes
Dec 13, 2019
Dmitri Smirnov (yuslepukhin)
deleted the
yuslepukhin/import_featurizers
branch
December 14, 2019 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This imports Featurizers library as optional external project so the sources
are pulled in only when necessary.
Disabled automl on CentOS since the source is not ready.
*Motivation and Context
Previous import was in ORT code base. This imports a GH repository with the latest.