Skip to content

[TRT RTX EP] Remove unused legacy code from TRT EP that is no longer supported for TRT RTX - #25916

Closed
Maximilian Müller (gedoensmax) wants to merge 7 commits into
microsoft:mainfrom
gedoensmax:maximilianm/remove_dead_code
Closed

[TRT RTX EP] Remove unused legacy code from TRT EP that is no longer supported for TRT RTX#25916
Maximilian Müller (gedoensmax) wants to merge 7 commits into
microsoft:mainfrom
gedoensmax:maximilianm/remove_dead_code

Conversation

@gedoensmax

@gedoensmax Maximilian Müller (gedoensmax) commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Description

This PR cleans up the codebase of the EP and fixes some compile issues.

@jywu-mysoft

George Wu (jywu-mysoft) commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

please resolve conflicts? Maximilian Müller (@gedoensmax) , I assume this and the other RTX EP changes should be all taken in together?

@jywu-mysoft George Wu (jywu-mysoft) added the ep:NvRTX NV RTX execution provider label Sep 2, 2025
@gedoensmax

Maximilian Müller (gedoensmax) commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

This would not be strictly needed within 1.23.

@jywu-mysoft

George Wu (jywu-mysoft) commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

This would not be strictly needed within 1.23.

would it make it difficult to cherry pick other PR's if they are based on your changes? are there any other upcoming PR's targeting 1.23?

@gedoensmax

Maximilian Müller (gedoensmax) commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

@jywu-msft So far none are planned. There could of course be other minor fixes that we notice like: #25937

@gedoensmax

Maximilian Müller (gedoensmax) commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

I rebased this branch. Can I get a rerun of the tests to get this merged ?

@gedoensmax

Maximilian Müller (gedoensmax) commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

Chi Lo (@chilo-ms) can you run the CI on this and merge ?

@chilo-ms

Chi Lo (chilo-ms) commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Oct 20, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 4 pipeline(s).

@chilo-ms

Chi Lo (chilo-ms) commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Do we want this PR to be in ORT now?
How about waiting for the TRT RTX EP pipelines PR to be merged first? then we can run test against this PR in the pipelines.

@gedoensmax

Maximilian Müller (gedoensmax) commented Oct 22, 2025

Copy link
Copy Markdown
Contributor Author

Yeah that works for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ep:NvRTX NV RTX execution provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gedoensmax @jywu-mysoft @chilo-ms @theHamsta