[AIX] test-suites failure fixes - #25791
Conversation
|
Changming Sun (@snnn) Tianlei Wu (@tianleiwu) Dmitri Smirnov (@yuslepukhin) Also, please trigger CI workflows for this PR. |
… handling in ort_graph_to_proto.h
|
Also, for handling external data I have added ConvertExternalData() in ort_graph_to_proto.h which will be called in case be BE system Before writing data to file. With this change, all tests for onnxruntime_ep_graph_test are passing. |
|
Dmitri Smirnov (@yuslepukhin) I will spend time for rest failures and will raise separate PR. |
|
Added more comments, this also needs to be rebased. |
Will address these comments in next commit. Thanks for reviewing it. |
|
I see in some OS Ci's is failing with below . I will change and make this method as API . Wondering why it's not hit in all OS. |
|
Dmitri Smirnov (@yuslepukhin) Adrian Lizarraga (@adrianlizarraga) |
|
Dmitri Smirnov (@yuslepukhin) In windows debug X64, I see below . But same is passing in release mode. |
|
Hi Dmitri Smirnov (@yuslepukhin) |
|
Dmitri Smirnov (@yuslepukhin) Update the code to handle unreferenced function parameters |
|
You can comment out the names of the unreferenced params |
|
Dmitri Smirnov (@yuslepukhin) |
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Dmitri Smirnov (@yuslepukhin) |
|
Dmitri Smirnov (@yuslepukhin) |
|
/azp run Windows ARM64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi Dmitri Smirnov (@yuslepukhin) Tianlei Wu (@tianleiwu) |
|
Dmitri Smirnov (@yuslepukhin) |
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
760eea4
into
microsoft:main
|
Dmitri Smirnov (@yuslepukhin) Tianlei Wu (@tianleiwu) |
### Description This PR is to fix some of the test case failures mentioned in microsoft#25790 1. cmake/onnxruntime_unittests.cmake To fix the onnxruntime_shared_lib_test crash 2. include/onnxruntime/core/providers/utils/ort_graph_to_proto.h Added method for handling external data. For fixing , EpGraphTest.SerializeToProto_ConstantOfShape , EpGraphTest.SerializeToProto_Mnist, EpGraphTest.SerializeToProto_InputModelHasExternalIni 3. onnxruntime/core/framework/tensorprotoutils.cc For fixing many test failures , related to float16 or Int16 type. 4. onnxruntime/test/framework/endian_test.cc For fixing, ConvertRawDataInTensorProtoTest.FloatData and ConvertRawDataInTensorProtoTest.Int32Data ### Motivation and Context To fix the AIX (Big endian) related test failures.
Description
This PR is to fix some of the test case failures mentioned in #25790
To fix the onnxruntime_shared_lib_test crash
Added method for handling external data.
For fixing , EpGraphTest.SerializeToProto_ConstantOfShape , EpGraphTest.SerializeToProto_Mnist, EpGraphTest.SerializeToProto_InputModelHasExternalIni
For fixing many test failures , related to float16 or Int16 type.
For fixing, ConvertRawDataInTensorProtoTest.FloatData and ConvertRawDataInTensorProtoTest.Int32Data
Motivation and Context
To fix the AIX (Big endian) related test failures.