DynamicQuantizeMatMul - handle case where B zero point input is provided but not constant. - #25544
Merged
George Wu (jywu-mysoft) merged 7 commits intoJul 26, 2025
Conversation
…ded but not constant.
Hariharan Seshadri (hariharans29)
previously approved these changes
Jul 25, 2025
Hariharan Seshadri (hariharans29)
left a comment
Hariharan Seshadri (hariharans29)
left a comment
Member
There was a problem hiding this comment.
LGTM
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Hariharan Seshadri (hariharans29)
approved these changes
Jul 26, 2025
Edward Chen (edgchen1)
marked this pull request as ready for review
July 26, 2025 02:01
George Wu (jywu-mysoft)
deleted the
edgchen1/dynamic_quantize_matmul_b_zp_check
branch
July 26, 2025 04:39
|
Thanks Edward Chen (@edgchen1) for handling this case. |
Changming Sun (snnn)
pushed a commit
that referenced
this pull request
Jul 28, 2025
…ded but not constant. (#25544) ### Description <!-- Describe your changes. --> In DynamicQuantizeMatMul KleidiAI-specific prepacking logic, handle case where B zero point input is provided but not constant. In this case, we should not prepack. Add some unit tests that test the prepacking code path. Add check for ARM SME instructions in DynamicQuantizeMatMul before calling `MlasDynamicQGemmBatch()` and associated functions. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Follow up to #25187
Merged
Changming Sun (snnn)
pushed a commit
that referenced
this pull request
Jul 28, 2025
Changming Sun (snnn)
pushed a commit
that referenced
this pull request
Jul 30, 2025
- DynamicQuantizeMatMul - handle case where B zero point input is provided but not constant. (#25544) - Refactor plugin EP support (#25541) - Remove the python installation steps from win-qnn-arm64-ci-pipeline.yml (#25552) - [EP ABI] Node_GetAttrByName returns ORT_NOT_FOUND with non-existing attr name (#25565) - Fix C/C++ documentation generation (#25569) - [build] fix multi-config for VCPKG (#25585)
Sanket Kale (sanketkaleoss)
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
…ded but not constant. (microsoft#25544) ### Description <!-- Describe your changes. --> In DynamicQuantizeMatMul KleidiAI-specific prepacking logic, handle case where B zero point input is provided but not constant. In this case, we should not prepack. Add some unit tests that test the prepacking code path. Add check for ARM SME instructions in DynamicQuantizeMatMul before calling `MlasDynamicQGemmBatch()` and associated functions. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Follow up to microsoft#25187
Sanket Kale (sanketkaleoss)
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
- **DynamicQuantizeMatMul - handle case where B zero point input is provided but not constant. (microsoft#25544)** - **Refactor plugin EP support (microsoft#25541)** - **Remove the python installation steps from win-qnn-arm64-ci-pipeline.yml (microsoft#25552)**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In DynamicQuantizeMatMul KleidiAI-specific prepacking logic, handle case where B zero point input is provided but not constant. In this case, we should not prepack.
Add some unit tests that test the prepacking code path.
Add check for ARM SME instructions in DynamicQuantizeMatMul before calling
MlasDynamicQGemmBatch()and associated functions.Motivation and Context
Follow up to #25187