Skip to content

Make sure the macosx binaries get signed #24605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baiju Meswani (baijumeswani) merged 2 commits into from
Apr 30, 2025
Merged

Make sure the macosx binaries get signed #24605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9941272
Sign the MacOS library and use that binary
baijumeswani Apr 29, 2025
1e9d98d
Use absolute paths
baijumeswani Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions tools/ci_build/github/azure-pipelines/custom-nuget-packaging-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ extends:
DoEsrp: true

- stage: NugetPackaging
dependsOn: [Windows_Packaging_CUDA, OnnxRuntime_QNN_Nuget_Win_Arm64, MacOS_C_API_Packaging_CPU]
dependsOn: [Windows_Packaging_CUDA, OnnxRuntime_QNN_Nuget_Win_Arm64, MacOS_C_API_Package_Publish]
jobs:
- job: CreateNugetPackage
pool: 'Onnxruntime-Win2022-GPU-A10'
Expand Down Expand Up @@ -121,16 +121,21 @@ extends:
targetPath: '$(Build.BinariesDirectory)/win-arm64'

- task: DownloadPipelineArtifact@0
displayName: 'Download Pipeline Artifact - osx-x64'
displayName: 'Download Pipeline Artifact - osx'
inputs:
artifactName: 'onnxruntime-osx-x86_64'
targetPath: '$(Build.BinariesDirectory)/osx-x64'
artifactName: 'onnxruntime-osx'
targetPath: '$(Build.BinariesDirectory)/osx'

- task: DownloadPipelineArtifact@0
displayName: 'Download Pipeline Artifact - osx-arm64'
- task: PowerShell@2
displayName: 'Create osx directories'
inputs:
artifactName: 'onnxruntime-osx-arm64'
targetPath: '$(Build.BinariesDirectory)/osx-arm64'
targetType: 'inline'
script: |
mkdir -p $(Build.BinariesDirectory)/osx-x64
Move-Item -Path $(Build.BinariesDirectory)/osx/onnxruntime-osx-x86_64* -Destination $(Build.BinariesDirectory)/osx-x64

mkdir -p $(Build.BinariesDirectory)/osx-arm64
Move-Item -Path $(Build.BinariesDirectory)/osx/onnxruntime-osx-arm64* -Destination $(Build.BinariesDirectory)/osx-arm64

- task: PowerShell@2
displayName: 'List all files downloaded'
Expand Down
6 changes: 2 additions & 4 deletions tools/ci_build/github/azure-pipelines/templates/mac-cpu-packaging-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,12 @@ stages:
ls -l
popd
displayName: tgz to zip

- template: mac-esrp-dylib.yml
parameters:
FolderPath: '$(Build.ArtifactStagingDirectory)'
DisplayName: 'ESRP - Sign Mac'
DoEsrp: true
Pattern: '*.zip'

- script: |
pushd '$(Build.ArtifactStagingDirectory)'
find . '*.zip' -exec unzip {} \;
Expand All @@ -136,5 +136,3 @@ stages:
targetPath: '$(Build.ArtifactStagingDirectory)'
artifactName: 'onnxruntime-osx'
condition: 'succeededOrFailed()'


10 changes: 1 addition & 9 deletions tools/ci_build/github/azure-pipelines/templates/mac-esrp-dylib.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
parameters:
- name: DoEsrp
type: boolean
default: true

- name: FolderPath
type: string
default: ''

- name: DisplayName
type: string
default: ''

- name: Pattern
type: string
default: '*.zip'
Expand All @@ -27,7 +19,7 @@ steps:
AuthSignCertName: '53d54d02-978d-4305-8572-583cf6711c4f'

FolderPath: ${{ parameters.FolderPath }}
Pattern: '*.nupkg'
Pattern: ${{ parameters.Pattern }}
SessionTimeout: 90
ServiceEndpointUrl: 'https://api.esrp.microsoft.com/api/v2'
MaxConcurrency: 25
Expand Down