[Optimizer] Fix exception for Q -> DQ sequence with different scale types - #23771
Merged
Adrian Lizarraga (adrianlizarraga) merged 5 commits intoFeb 21, 2025
Merged
Conversation
Adrian Lizarraga (adrianlizarraga)
marked this pull request as ready for review
February 21, 2025 06:25
Adrian Lizarraga (adrianlizarraga)
requested review from
Hector Li (HectorSVC) and
Edward Chen (edgchen1)
February 21, 2025 06:27
…f the DoubleQDQPairsRemover is ever changed to L2
Adrian Lizarraga (adrianlizarraga)
requested a review
from Jeff Bloomfield (jeffbloo)
February 21, 2025 06:45
George Wu (jywu-mysoft)
approved these changes
Feb 21, 2025
Hector Li (HectorSVC)
approved these changes
Feb 21, 2025
Adrian Lizarraga (adrianlizarraga)
deleted the
adrianl/optimizer-bug-qdq-diff-scale-types
branch
February 21, 2025 16:26
Guenther Schmuelling (guschmue)
pushed a commit
that referenced
this pull request
Mar 6, 2025
…ypes (#23771) ### Description Fixes bug in the IsQDQPairSupported utility function, which is used by various QDQ optimizers (e.g., DoubleQDQPairsRemover, QDQFinalCleanup, etc.). The bug causes an exception when IsQDQPairIsSupported() is called with a `Q(scale_f32) -> DQ(scale_f16)` sequence that uses different scale types. ### Motivation and Context Fix bug that prevents creating QDQ models that use scales of different types.
Ashrit Shetty (ashrit-ms)
pushed a commit
that referenced
this pull request
Mar 17, 2025
…ypes (#23771) ### Description Fixes bug in the IsQDQPairSupported utility function, which is used by various QDQ optimizers (e.g., DoubleQDQPairsRemover, QDQFinalCleanup, etc.). The bug causes an exception when IsQDQPairIsSupported() is called with a `Q(scale_f32) -> DQ(scale_f16)` sequence that uses different scale types. ### Motivation and Context Fix bug that prevents creating QDQ models that use scales of different types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in the IsQDQPairSupported utility function, which is used by various QDQ optimizers (e.g., DoubleQDQPairsRemover, QDQFinalCleanup, etc.). The bug causes an exception when IsQDQPairIsSupported() is called with a
Q(scale_f32) -> DQ(scale_f16)sequence that uses different scale types.Motivation and Context
Fix bug that prevents creating QDQ models that use scales of different types.