[JSEP/WebGPU] Add a fatal error message for unsupported GQA do_rotary attribute. - #23287
Merged
Guenther Schmuelling (guschmue) merged 1 commit intoJan 9, 2025
Conversation
Satya Kumar Jandhyala (satyajandhyala)
added
the
ep:WebGPU
Satya Kumar Jandhyala (satyajandhyala)
changed the title
Guenther Schmuelling (guschmue)
approved these changes
Jan 8, 2025
Guenther Schmuelling (guschmue)
deleted the
sajandhy/webgpu_gqa_do_rotary_not_supported
branch
January 9, 2025 16:52
Guenther Schmuelling (guschmue)
pushed a commit
that referenced
this pull request
Jan 12, 2025
… attribute. (#23287) ### Description <!-- Describe your changes. --> Added a fatal error message for unsupported GroupQuerryAttention do_rotary attribute. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #22987 Help user understand that this attribute is not supported.
Ashrit Shetty (ashrit-ms)
pushed a commit
that referenced
this pull request
Mar 17, 2025
… attribute. (#23287) ### Description <!-- Describe your changes. --> Added a fatal error message for unsupported GroupQuerryAttention do_rotary attribute. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #22987 Help user understand that this attribute is not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a fatal error message for unsupported GroupQuerryAttention do_rotary attribute.
Motivation and Context
#22987
Help user understand that this attribute is not supported.