Update OrtApi 17 marker - #19897
Merged
Rachel Guo (YUNQIUGUO) merged 2 commits intoMar 18, 2024
Merged
Update OrtApi 17 marker#19897
Conversation
Rachel Guo (YUNQIUGUO)
requested review from
Pranav Sharma (pranavsharma) and
Changming Sun (snnn)
March 13, 2024 18:19
Changming Sun (snnn)
previously approved these changes
Mar 13, 2024
Pranav Sharma (pranavsharma)
previously approved these changes
Mar 14, 2024
Pranav Sharma (pranavsharma)
left a comment
Pranav Sharma (pranavsharma)
left a comment
Contributor
There was a problem hiding this comment.
1.17.2 is already released. You want to merge this into 1.17.3.
Contributor
|
Pranav Sharma (@pranavsharma) The 1.17.2 tag is not created yet. |
Contributor
Author
|
looks like the required tensorRT pipeline is failing. wanted to get this pr checked in Changming Sun (@snnn) are you aware of any fixes that probably needs to get cherry-picked in for this branch? (i.e. fixes happened after branch rel-1.17.2) |
Contributor
|
Please cherry-pick #19880 . |
fix build break caused by image update. tensorrt isn't expected to pass all onnx node tests.
Rachel Guo (YUNQIUGUO)
dismissed stale reviews from Pranav Sharma (pranavsharma) and Changming Sun (snnn)
via
March 15, 2024 01:03
f0c359c
Changming Sun (snnn)
approved these changes
Mar 15, 2024
Contributor
Author
|
Pranav Sharma (@pranavsharma) need another approval:) |
Pranav Sharma (pranavsharma)
approved these changes
Mar 18, 2024
Yulong Wang (fs-eire)
pushed a commit
that referenced
this pull request
Mar 21, 2024
### Description <!-- Describe your changes. --> Looks like a bunch of new C OrtApis are introduced in 1.17.0 time frame, however the static assert sanity check has not been updated along the prs. Fix OrtApi marker. Related issue: #19893 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> The branch is checked out against rel-1.17.2. Once rel-1.17.3 is made, it will be based on this right version. --------- Co-authored-by: rachguo <rachguo@rachguos-Mini.attlocal.net> Co-authored-by: George Wu <jywu@microsoft.com>
Merged
Yulong Wang (fs-eire)
added a commit
that referenced
this pull request
Mar 22, 2024
### Description the release branch `rel-1.17.3` is created based on `rel-1.17.2` last week. However, there are latest code change merged into `rel-1.17.2`: #19897. The branch `rel-1.17.3` is protected so no push or delete can be performed on it. This PR cherry-picks the commit 633c22f based on 6bc6adc to make sure the base of `rel-1.17.3` matches `rel-1.17.2`. @snnn @pranavsharma This operation will ensure the code base contains same code, but the git history will not be exactly same. If you want it to be exactly same, I need your help to do a git rebase or delete and recreate the branch. Co-authored-by: Rachel Guo <35738743+YUNQIUGUO@users.noreply.github.com> Co-authored-by: rachguo <rachguo@rachguos-Mini.attlocal.net> Co-authored-by: George Wu <jywu@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like a bunch of new C OrtApis are introduced in 1.17.0 time frame, however the static assert sanity check has not been updated along the prs.
Fix OrtApi marker.
Related issue:
#19893
Motivation and Context
The branch is checked out against rel-1.17.2. Once rel-1.17.3 is made, it will be based on this right version.