enable sse4.1 optimizations for gemmlowp - #1529
Merged
Ashwini Khade (askhade) merged 1 commit intoAug 1, 2019
Merged
Conversation
Changming Sun (snnn)
approved these changes
Jul 31, 2019
| # For x86 platforms it is important to pass this flag to compiler. Without this gemmlowp will use slow reference code. | ||
| # These optimizations are not enabled on MSVC so excluding it. | ||
| message("enabling optimizations for gemmlowp") | ||
| set_source_files_properties("${ONNXRUNTIME_ROOT}/core/providers/cpu/math/matmul_integer.cc" PROPERTIES COMPILE_FLAGS "-msse4.1") |
Contributor
There was a problem hiding this comment.
wondering if you tried the gemmlowp avx2 path, does that make a measurable difference?
Contributor
Author
There was a problem hiding this comment.
yes I tried that ... it does not
Dmitri Smirnov (yuslepukhin)
deleted the
askhade/update_compileflags_gemmlowp
branch
August 6, 2019 17:02
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes - Migrate pipeline linux test to docker image. - Skip failed tests for further investigation. Potential fail reasons: - python 3.10 - onnxruntime 1.20 - docker in docker ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Enable sse4.1 optimizations for gemmlowp
Motivation and Context
For x86 platforms it is important to pass this flag to compiler. Without this gemmlowp will use slow reference code.