Kezhan/separate op def from kernels - #143
Merged
Ke Zhang (linkerzhang) merged 10 commits intoDec 11, 2018
Merged
Conversation
…ls when doing export
…o kezhan/separate_op_def_from_kernels
Contributor
|
Should we rename contrib_ops.h to contrib_defs.h to make it more consistent with ONNX? |
…o kezhan/separate_op_def_from_kernels
Pranav Sharma (pranavsharma)
previously approved these changes
Dec 11, 2018
|
|
||
| #include "core/framework/op_kernel.h" | ||
| #include "core/framework/kernel_registry.h" | ||
| #include "onnx/defs/schema.h" |
Contributor
There was a problem hiding this comment.
replace this line with:
#include "onnxruntime/core/graph/onnx_protobuf.h"It will solve your current build failure.
Contributor
Author
There was a problem hiding this comment.
thank you very much! Changming.
…o kezhan/separate_op_def_from_kernels
Contributor
|
environment.cc belongs to onnxruntime_framework project. |
Contributor
Author
|
Changming Sun (@snnn) thank you! those schemas only depend on "graph", to avoid any issues later, I put them in graph now. |
Changming Sun (snnn)
approved these changes
Dec 11, 2018
Ke Zhang (linkerzhang)
deleted the
kezhan/separate_op_def_from_kernels
branch
December 12, 2018 00:15
Ted Themistokleous (TedThemistokleous)
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.