Add validation of shape when re-using a buffer in ExecutionFrame - #1356
Merged
Scott McKay (skottmckay) merged 6 commits intoJul 9, 2019
Merged
Conversation
Validate shape is compatible at runtime when re-using Tensor.
…imParamHandlingInBufferReuse
Validate shape is compatible at runtime when re-using Tensor.
…ps://github.com/Microsoft/onnxruntime into skottmckay/ImproveDimParamHandlingInBufferReuse
Scott McKay (skottmckay)
requested review from
G. Ramalingam (gramalingam),
Xavier Dupré (xadupre) and
Dmitri Smirnov (yuslepukhin)
July 8, 2019 11:03
Scott McKay (skottmckay)
changed the title
Contributor
|
I have approved it w/o comments bc I participated in debugging and had preliminary discussions with Scott McKay (@skottmckay) |
Scott McKay (skottmckay)
deleted the
skottmckay/ImproveDimParamHandlingInBufferReuse
branch
July 9, 2019 05:12
Contributor
|
Looks like this change broke some models. |
Dmitri Smirnov (yuslepukhin)
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Quantize: CLI command to quantize input model
Usage:
```bash
olive quantize \
--model_name_or_path <model-name> \
--trust_remote_code \
--device <cpu|gpu|npu> \
--algorithms <awq,gptq> \
--data_name <data-name> \
--subset <subset-name> \
--split <split-name> \
--batch_size <batch-size> \
--output_path <output-dir>
```
## Checklist before requesting a review
- [x] Add unit tests for this change.
- [x] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [x] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.
## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Validate that the size of the shape matches when re-using a buffer in the execution frame.
Don't consider an empty string to be a matching dim_param value.
Motivation and Context
Issue #1331 involved a model where 'None' was accidentally being used as a dim_param value in multiple places where the values were not equal. 'None' is not a special word, so it was treated as a variable name. Whilst we can't prevent this sort of misuse of dim_param, we can detect when it leads to invalid buffer re-use by validating the number of elements is the same.
Additionally we shouldn't consider an empty string in dim_param to be a valid variable name, so update the allocation planner to not consider two empty strings to be equal.
Add a unit test involving the model from the issue.