Skip to content

Copy shared library in Dockerfile.server - #1347

Merged
George Wu (jywu-mysoft) merged 1 commit into
microsoft:masterfrom
NonStatic2014:bohu/add_so_in_dockerfile
Jul 8, 2019
Merged

Copy shared library in Dockerfile.server#1347
George Wu (jywu-mysoft) merged 1 commit into
microsoft:masterfrom
NonStatic2014:bohu/add_so_in_dockerfile

Conversation

@non-static

Copy link
Copy Markdown
Contributor

Description: Copy ORT shared library to /lib in the ORT Server Dockerfile.

Motivation and Context
After PR 1271, the ONNX Runtime Server needs the ONNX Runtime shared library. So we need to add it into the Dockerfile as well.

@non-static
NonStatic (non-static) requested a review from a team as a code owner July 5, 2019 00:37

@snnn Changming Sun (snnn) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to run ldconfig after that

@non-static

Copy link
Copy Markdown
Contributor Author

You may need to run ldconfig after that

In this change, I put the .so file into the /lib/ directory, so I don't think ldconfig is needed.

@snnn

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 22 pipeline(s).

@jywu-mysoft
George Wu (jywu-mysoft) merged commit 9f9ff19 into microsoft:master Jul 8, 2019
Dmitri Smirnov (yuslepukhin) pushed a commit that referenced this pull request Mar 17, 2026
## Describe your changes

custom data config doesn't have `type`.

## Checklist before requesting a review
- [ ] Add unit tests for this change.
- [ ] Make sure all tests can pass.
- [ ] Update documents if necessary.
- [ ] Lint and apply fixes to your code by running `lintrunner -a`
- [ ] Is this a user-facing change? If yes, give a description of this
change to be included in the release notes.
- [ ] Is this PR including examples changes? If yes, please remember to
update [example
documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md)
in a follow-up PR.

## (Optional) Issue link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants