Skip to content

Uninstall the preinstalled cmake in tensorrt image because it's too old - #1316

Merged
Raymond Yang (raymondxyang) merged 1 commit into
masterfrom
snnn/p6
Jul 1, 2019
Merged

Uninstall the preinstalled cmake in tensorrt image because it's too old#1316
Raymond Yang (raymondxyang) merged 1 commit into
masterfrom
snnn/p6

Conversation

@snnn

@snnn Changming Sun (snnn) commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

Description:
Uninstall the preinstalled cmake in tensorrt image because it's too old that it can't be used for building onnxruntime. Also, it's the default one.

Motivation and Context

  • Why is this change required? What problem does it solve?
    By default, when people run build.sh in tensorrt's docker image, it will fail, because cmake version is too old, even there is a newer one in /usr.

  • If it fixes an open issue, please link to the issue here.

@snnn
Changming Sun (snnn) requested a review from a team as a code owner June 28, 2019 19:00
@raymondxyang
Raymond Yang (raymondxyang) merged commit 28759e2 into master Jul 1, 2019
@raymondxyang
Raymond Yang (raymondxyang) deleted the snnn/p6 branch July 1, 2019 22:08
Dmitri Smirnov (yuslepukhin) pushed a commit that referenced this pull request Mar 17, 2026
## Describe your changes
Document LoRA feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants