Use manylinux2010 image to build linux python wheels - #1282
Conversation
|
Probably also fixes #1113 |
|
/azp run |
|
Azure Pipelines successfully started running 22 pipeline(s). |
c4db9fa to
fc35293
Compare
|
Thanks for the work! The manylinux2010 and auditwheel really helps our distribution. I queued it in release pipeline for validation. |
Raymond Yang (raymondxyang)
left a comment
Raymond Yang (raymondxyang)
left a comment
There was a problem hiding this comment.
It looks the changes in cmake is breaking the Windows build. I'll take a look tomorrow
fc35293 to
5dbd51b
Compare
|
I pushed a new commit reverting a change introduced in |
|
I'll unblock the Windows failure tomorrow (some build environment related issue). Sorry for the delay.. |
|
Hi Matthieu Darbois (@mayeut) could you pull ziya/update-cuda branch to unblock the windows build? I already altered the VMs for cuda 10. |
|
For the Linux fail on mnist model, it's a known flaky case (we are looking into it) and we will check in your PR first. |
Allow wheels built to truly be compliant with a manylinux policy
5dbd51b to
14380b6
Compare
|
|
/azp run |
|
Azure Pipelines successfully started running 22 pipeline(s). |
|
Thanks for the contribution :))) |
| ln -s python /opt/onnxruntime-python/bin/python${PYTHON_VER} | ||
| fi | ||
| python -m pip install --upgrade --force-reinstall pip==19.1.1 | ||
| python -m pip install --upgrade --force-reinstall numpy==1.16.3 |
There was a problem hiding this comment.
This line must be fixed. Raymond Yang (@raymondxyang)
3 participants
Description: Use manylinux2010 docker image to build linux python wheels.
Motivation and Context
Before this change, linux wheels were built on Ubuntu 16.04 and were renamed manylinux1 wheels in order to be uploaded to PyPI. However, they do not respect the manylinux1 policy and the result is that
pip install onnxruntimeinstall those none compliant packages on system that don't support them. Building on manylinux2010 docker image allow wheels built to truly be compliant with a manylinux policy in order to provide onnxruntime to a wider audience.This fixes Need CentOS support #1001