Skip to content

MKLDNN Sum and Batch Normalizaton kernels - #115

Merged
Pranav Sharma (pranavsharma) merged 11 commits into
microsoft:masterfrom
sreekanth-yalachigere:master
Dec 8, 2018
Merged

Pranav Sharma (pranavsharma) merged 11 commits into
microsoft:masterfrom
sreekanth-yalachigere:master

Conversation

@sreekanth-yalachigere

Copy link
Copy Markdown
Contributor

Sum Kernel

core\providers\mkldnn\math\sum.cc
core\providers\mkldnn\math\sum.h

Modified base class Sum_6 in core\providers\cpu\math\element_wise_ops.h Removed final
for mkldnn to fallback to cpu computation.

Batch Norm Kernel

core\providers\mkldnn\nn\batch_norm.cc
core\providers\mkldnn\nn\batch_norm.h

Modified base class onnxruntime::BatchNorm in file core\providers\cpu\nn\batch_norm.h
Removed final and made epsilon_ as protected member.

@sreekanth-yalachigere

Copy link
Copy Markdown
Contributor Author

Pranav Sharma (@pranavsharma) how to kick off CI pipeline?

@jywu-mysoft George Wu (jywu-mysoft) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you sync master? I think there are changes here that aren't yours.

@sreekanth-yalachigere

Copy link
Copy Markdown
Contributor Author

@jywu-msft I noticed it. I am having problems to sync master.
getting the following message when I try to merge upstream/master

merge: upsteam/master - not something we can merge
Can I close this create a new PR?

@jywu-mysoft

Copy link
Copy Markdown
Contributor

did you fetch upstream to pull in the latest and then merge?

@sreekanth-yalachigere

Copy link
Copy Markdown
Contributor Author

yes

@sreekanth-yalachigere

Copy link
Copy Markdown
Contributor Author

@jywu-msft I now only see my changes. Can you please take a look?

Comment thread onnxruntime/core/providers/mkldnn/nn/batch_norm.h Outdated
Comment thread onnxruntime/core/providers/mkldnn/nn/batch_norm.cc
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/nn/batch_norm.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/math/sum.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/nn/batch_norm.cc Outdated
Comment thread onnxruntime/core/providers/mkldnn/nn/batch_norm.cc Outdated
Changming Sun (snnn) pushed a commit that referenced this pull request Dec 11, 2018
Changming Sun (snnn) pushed a commit that referenced this pull request Dec 12, 2018
* Revert "mkldnn activations.relu (#86)"

This reverts commit 6d80253.

* Revert "MKLDNN Sum and Batch Normalizaton kernels (#115)"

This reverts commit bdd5e58.
Dmitri Smirnov (yuslepukhin) pushed a commit that referenced this pull request Mar 17, 2026
…web/frontend/loader-utils-1.4.2

Bump loader-utils from 1.4.0 to 1.4.2 in /olive/web/frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants