VM Connect Changes#312
Open
hvedati wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
han-sogawa-microsoft
approved these changes
Jun 26, 2025
han-sogawa-microsoft
left a comment
han-sogawa-microsoft
left a comment
Member
There was a problem hiding this comment.
Approve, just need remove the changed references before merge
blairurish
reviewed
Jun 27, 2025
| return nil, err | ||
| } | ||
|
|
||
| mocResponse, err := c.VirtualMachineAgentClient.GetHyperVVmId(ctx, vm[0]) |
Contributor
There was a problem hiding this comment.
Just to be safe, can we make sure the vm list is non-empty before accessing it? Same applies to lines 437 and 454
Altayl
reviewed
Jun 27, 2025
kumdeepakgit
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.